fix: overlapping

[afham123]

Issues

• As correctly pointed out by @BearAlliance "In practice the 'bridge' was not equivalent to prevTail + curHead, it effectively dropped the previous tail." Toggle is adding the overlapping bridge alternately.
• Initialising tmpString inside the loop does not preserves its value across iterations, instead loosing its value with iteration.
• Few redundant if conditions were there.
• Few cases we are slicing a string by byte positions, this can break non ascii character words containing char like ñ or emoji. The code only works reliably with text is made of simple one-byte characters, like plain English letters, digits, and punctuation.

s := "añ🌍"
len(s)          // 8  (a=1, ñ=2, 🌍=4 bytes)
len([]rune(s))  // 3  (3 characters)

Improved overlapping logic:

• Adding a consistent bridge overlapping.
• Preallocating the result slice to its final size, reducing repeated reallocations during each loop iteration.
• Removing redundant if else block and adding a clean simplified logic.
• Adding the rune in the bridge making also.
• Merging the two loop into just one, reducing the time-complexity from 2n to just simply n, would be useful in case of a big minified file.

Before

• Please note that overlapping got corrupt.

After

[BearAlliance]

This is only a partial fix. It still uses the old toggle scheme, so it only builds overlap bridges for alternating chunks. With chunks A, B, C, D, it produces bridges for A+B and C+D. It still misses B+C`.

See my comment #223 (comment)

[afham123]

This is only a partial fix. It still uses the old toggle scheme, so it only builds overlap bridges for alternating chunks. With chunks A, B, C, D, it produces bridges for A+B and C+D. It still misses B+C`.

See my comment #223 (comment)

Yes, make sense let me add your change, thanks for pointing out, I didn't think through.

[BearAlliance]

If you're going to move ahead with this one, you should probably also copy the tests from my PR.

[grinish21]

Can we add a test case for this change.

[afham123]

Test case added.