Fix install.sh if clause#39
Open
sebix wants to merge 1 commit into
Open
Conversation
`==` with wildcard only works in bash, `[[` is also bash-only, not bourne-shell which is used in this script. To compare with wildcard in bourne-shell we can use the case statement
|
|
|
Same issue encountered here, fixed by replacing #!/bin/sh by #!/bin/bash on my side |
Author
|
Switching to bash would have been the other solution, but that requires bash, probably adding a new dependency (which is often available but not on minimal installations). I therefore opted to stick with the bourne shell. But it's up to the maintainers to decide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
==with wildcard only works in bash,[[is also bash-only, not bourne-shell which is used in this script.To compare with wildcard in bourne-shell we can use the case statement