Fix RON formatting for Amethyst#38
Open
conectado wants to merge 2 commits into
Open
Conversation
As explained in amethyst#32 relying on the OS to expand globs caused the CLI to fail in Windows. By using glob it is currently working on Windwos.
When generating the `RON` Amethyst's asset loader wasn't able to read the resouces. However, when adding this wrapper when generating the `RON` the struct `SerializedSpriteSheet` is wrapped within a `List()` as per shown in Amethyst's examples, making it work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to load an sprite sheet generated by the CLI using:
I was getting and error due to the formatting of
sprites/sprite_sheet.ronWhen comparing the
rongenerated by the cli with theronprovided by Amethyst's examples I found out that theSpritestruct was wrapped with aListenum. So by doing the same with the output ofAmethystFormatI managed to fix this problem.Note: This PR includes a fix of #32 which I realize is fixed in #33 but was never merged and is currently outdated. If needed I can make a branch including only
436bec5 .