fix: unwrap nested ConversationEvent in SDK resource layer#35
Merged
johnxing-amigo merged 1 commit intomainfrom Mar 14, 2026
Merged
fix: unwrap nested ConversationEvent in SDK resource layer#35johnxing-amigo merged 1 commit intomainfrom
johnxing-amigo merged 1 commit intomainfrom
Conversation
The generated Pydantic models wrap interact stream events in a nested RootModel chain: InteractResponse.root → ConversationEvent.root → InteractionCompleteEvent. This meant callers had to manually unwrap two levels to check event types. Now the SDK resource layer unwraps ConversationEvent automatically, so callers get concrete event types (InteractionCompleteEvent, NewMessageEvent, etc.) directly from evt.root. Also: - Update default SERVICE_ID to active dogfood service - Add AMIGO_TEST_SERVICE_ID to CI env - Add --no-cov to integration test run (coverage threshold is for unit tests) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConversationEventRootModel wrapper in interact streamsInteractionCompleteEvent,NewMessageEvent, etc.) directly fromevt.rootSERVICE_IDto active dogfood service--no-covto integration test CI (coverage threshold is for unit tests only)Test plan
evt.rootdirectly — no_unwrap_eventhelper needed🤖 Generated with Claude Code