feat: add nginx reverse-proxy and tls config#136
Open
edgar-pfennig wants to merge 1 commit intoamikos-tech:mainfrom
Open
feat: add nginx reverse-proxy and tls config#136edgar-pfennig wants to merge 1 commit intoamikos-tech:mainfrom
edgar-pfennig wants to merge 1 commit intoamikos-tech:mainfrom
Conversation
Contributor
|
@edgar-pfennig, I think we can do better than this. How do you feel about refactoring this into ingress. We can start simple with the default nginx ingress controller, although it is being deprecated I think around this time - https://kubernetes.io/blog/2025/11/11/ingress-nginx-retirement/ so perhaps something like Envoy can be a good use case. I think that adding directly in the deployment makes heavier than it needs to be - e.g. more configuration and more complexity. Let me know what you think. |
Author
@tazarov Actually good point, let me look at this and get back to you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @tazarov,
I worked on the TLS part using an nginx proxy as recommended in the chroma docs.