fix: sync SDK with Etsy API spec — March 2026 release - #18
Merged
Conversation
Agent-Logs-Url: https://github.com/amitray007/etsy-python-sdk/sessions/e9a81aac-5766-4f24-9cf0-1bbd28b70777 Co-authored-by: amitray007 <51674969+amitray007@users.noreply.github.com>
Claude
AI
changed the title
Contributor
Test Coverage ReportOverall: 93% (1533/1643 statements covered) Coverage by file
Updated by PR Tests |
There was a problem hiding this comment.
Pull request overview
Updates the Etsy v3 Python client to align with the latest OAS spec by adding the is_safe query parameter to the active listings search endpoint, and adjusts several deprecation warnings to use the repository’s preferred parenthesized multi-line string formatting.
Changes:
- Add
is_safe: Optional[bool] = NonetoListingResource.find_all_listings_active()and include it in the request query params. - Update multi-line
warnings.warn()messages to use explicit parenthesized string grouping. - Add tests covering
is_safe=Truepass-through and the defaultNonebehavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_listing_resource.py | Adds unit tests validating is_safe query param behavior. |
| etsy_python/v3/resources/Listing.py | Adds is_safe optional parameter and forwards it into query params for /listings/active. |
| etsy_python/v3/resources/Payment.py | Updates deprecated method warning string formatting. |
| etsy_python/v3/resources/ShippingProfile.py | Updates deprecated method warning string formatting. |
| etsy_python/v3/models/Listing.py | Updates deprecation warning string formatting in request models. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Revert cosmetic parenthesization of multi-line strings in warnings.warn() calls — implicit string concatenation inside function calls is standard Python and doesn't need wrapping - Update specs/baseline.json to 2026-03-24 spec - Update specs/last-release-check.json to track latest release Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
amitray007
changed the title
amitray007
marked this pull request as ready for review
March 30, 2026 12:56
Bumps [requests](https://github.com/psf/requests) from 2.32.4 to 2.33.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.4...v2.33.0) --- updated-dependencies: - dependency-name: requests dependency-version: 2.33.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_safeoptional boolean parameter tofind_all_listings_active()— filters out mature/adult content from search results3.0.0-general-release-2026-03-24requestsfrom 2.32.4 to 2.33.0 (CVE-2026-25645 security fix, cherry-picked from chore(deps): bump requests from 2.32.4 to 2.33.0 in /etsy_python #16)Test plan
pytest -v— 235 tests passis_safe=Truepasses through andis_safe=Noneis the defaultpython scripts/audit_sdk.pyconfirms no remaining parameter drift🤖 Generated with Claude Code