Conversation
|
It's not a bad idea, I just wonder if it should be implemented another way. Changing the default port will cause existing installs to break. Perhaps there is a way we can modify the port using an environment variable which would modify the port before Apache starts on running the container. |
|
isn't 80 just the port that the container is running? I don't really know enough but when i run a docker container i usually redirect 80 to the port i want with the run/compose file
it hasn't affected any of my internal services using 80 for the container. |
Right, but I believe the issue xardael is running into is running Ampache with host networking. When doing so, you're unable to redirect the ports. |
|
oh, i didn't know you could even do that. well then jut make it default to 80 in the pull would be the easiest way to change that |
|
I would not do that change and decline this MR.
Greetings Kae |
Default port 80 is not a good choice for running in host network, which you probably should when you want to run UPnP or MPD.