Update Psalm to 6.16.1 to fix #[\Override] false positives#143
Merged
Conversation
Psalm 6.15.1 reports false InvalidAttribute errors for #[\Override] on PHP 8.4.19+, breaking CI after GitHub runner updates.
- Replace ::set-output with $GITHUB_OUTPUT environment file - Update nick-invision/retry from v2 to v3 (Node.js 24 compatible)
The project transferred from nick-invision to nick-fields. v4 supports Node.js 24, resolving the deprecation warnings.
Member
|
Thanks! |
Member
|
I didn't notice before I clicked merge, but FYI, the version being pinned was intentional. Allowing Psalm to be upgraded can result in new issues being found, which is a headache for PRs. Thus we prefer to update the Psalm version intentionally, fixing the new issues found after upgrading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidAttributeerrors for#[\Override]on PHP 8.4.19+Noticed while working on #142 — all PRs against 3.x will fail static analysis until this is merged.