-
-
Notifications
You must be signed in to change notification settings - Fork 68
Add ForkContext #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add ForkContext #212
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8ac48fa
Add ForkContext
trowski 31d8b70
Updates
trowski 03a5cdd
Fix
trowski ffedc39
Fixup tests
danog 981895d
Fixup
danog e7333d0
Merge branch '2.x' into fork-context
trowski ec3d242
Fork context (#214)
danog e8207c4
Fix copy/pasta mistake
trowski 141c629
Look for StreamSelectLoop
trowski a538c04
Unused import
trowski 7c3509c
Merge branch '2.x' into fork-context
trowski 8a606f8
Fix loop type check
trowski 555a815
Merge branch 'refs/heads/2.x' into fork-context
trowski 125ac6f
Style fix after merge
trowski 45e791b
Close IPC channel immediately after callback finishes executing
trowski e732379
Remove commented-out tests
trowski 70f93ab
A couple notes
trowski b4c1bcf
Distinguish between send and receive
trowski bf4389c
Check for extensions
trowski 9be63d6
Don't call close in join
trowski 6e98e52
Change variable name to match interface suffix
trowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,7 @@ | |
| "SPL", | ||
| "standard", | ||
| "hash", | ||
| "pcntl" | ||
| "pcntl", | ||
| "posix" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace Amp\Parallel\Context; | ||
|
|
||
| use Amp\ByteStream\StreamChannel; | ||
| use Amp\Cancellation; | ||
| use Amp\Parallel\Context\Internal\AbstractContext; | ||
| use Amp\Parallel\Ipc\IpcHub; | ||
| use Amp\Serialization\NativeSerializer; | ||
| use Amp\Serialization\Serializer; | ||
| use Amp\TimeoutCancellation; | ||
| use Revolt\EventLoop; | ||
|
|
||
| /** | ||
| * USE AT YOUR OWN RISK! This context is not used by default in {@see DefaultContextFactory} because the timing of its | ||
| * creation must be purposeful and situational. | ||
| * | ||
| * Forking is not recommended at arbitrary points in an application since the entire state of the parent process is | ||
| * inherited into the child process, including the event-loop! | ||
| * | ||
| * Forking very early in an application, may be beneficial to copy state from the parent that was expensive to set up. | ||
| * | ||
| * This context is NOT compatible with event-loop extensions such as ext-uv or ext-ev. | ||
| * | ||
| * @template-covariant TResult | ||
| * @template-covariant TReceive | ||
| * @template TSend | ||
| * @extends AbstractContext<TResult, TReceive, TSend> | ||
| */ | ||
| final class ForkContext extends AbstractContext | ||
| { | ||
| private const DEFAULT_START_TIMEOUT = 5; | ||
|
|
||
| public static function isSupported(): bool | ||
| { | ||
| return \extension_loaded('pcntl') | ||
| && \extension_loaded('posix') | ||
| && \function_exists('pcntl_fork') // pcntl_fork may be disabled. | ||
| && EventLoop::getDriver()->getHandle() === null; | ||
| } | ||
|
|
||
| /** | ||
| * @param string|non-empty-list<string> $script Path to PHP script or array with first element as path and | ||
| * following elements options to the PHP script (e.g.: ['bin/worker.php', 'Option1Value', 'Option2Value']). | ||
| * @param positive-int $childConnectTimeout Number of seconds the child will attempt to connect to the parent | ||
| * before failing. | ||
| * | ||
| * @throws ContextException If starting the process fails. | ||
| */ | ||
| public static function start( | ||
| IpcHub $ipcHub, | ||
| string|array $script, | ||
| ?Cancellation $cancellation = null, | ||
| int $childConnectTimeout = self::DEFAULT_START_TIMEOUT, | ||
| Serializer $serializer = new NativeSerializer(), | ||
| ): self { | ||
| $key = $ipcHub->generateKey(); | ||
|
|
||
| // Fork | ||
| if (($pid = \pcntl_fork()) < 0) { | ||
| throw new ContextException("Forking failed: " . \posix_strerror(\posix_get_last_error())); | ||
| } | ||
|
|
||
| // Parent | ||
| if ($pid > 0) { | ||
| try { | ||
| $socket = $ipcHub->accept($key, $cancellation); | ||
| $ipcChannel = new StreamChannel($socket, $socket, $serializer); | ||
|
|
||
| $socket = $ipcHub->accept($key, $cancellation); | ||
| $resultChannel = new StreamChannel($socket, $socket, $serializer); | ||
| } catch (\Throwable $exception) { | ||
| $cancellation?->throwIfRequested(); | ||
|
|
||
| throw new ContextException("Connecting failed after forking", previous: $exception); | ||
| } | ||
|
|
||
| return new self($pid, $ipcChannel, $resultChannel); | ||
| } | ||
|
|
||
| // Child | ||
| \define("AMP_CONTEXT", "fork"); | ||
| \define("AMP_CONTEXT_ID", \getmypid()); | ||
|
|
||
| if (\is_string($script)) { | ||
| $script = [$script]; | ||
| } | ||
|
|
||
| $connectCancellation = new TimeoutCancellation((float) $childConnectTimeout); | ||
| Internal\runContext($ipcHub->getUri(), $key, $connectCancellation, $script, $serializer); | ||
|
|
||
| exit(0); | ||
| } | ||
|
|
||
| private ?int $exited = null; | ||
|
|
||
| private bool $weKilled = false; | ||
|
|
||
| /** | ||
| * @param StreamChannel<TReceive, TSend> $ipcChannel | ||
| */ | ||
| private function __construct( | ||
| private readonly int $pid, | ||
| StreamChannel $ipcChannel, | ||
| StreamChannel $resultChannel, | ||
| ) { | ||
| parent::__construct($ipcChannel, $resultChannel); | ||
| } | ||
|
|
||
| public function receive(?Cancellation $cancellation = null): mixed | ||
| { | ||
| $this->checkExit(false); // Will throw if the process exited unexpectedly. | ||
|
|
||
| return parent::receive($cancellation); | ||
| } | ||
|
|
||
| public function send(mixed $data): void | ||
| { | ||
| $this->checkExit(false); // Will throw if the process exited unexpectedly. | ||
|
|
||
| parent::send($data); | ||
| } | ||
|
|
||
| private function checkExit(bool $wait): ?int | ||
| { | ||
| if ($this->exited === null) { | ||
| if (\pcntl_waitpid($this->pid, $status, $wait ? 0 : \WNOHANG) === 0) { | ||
| return null; | ||
| } | ||
|
|
||
| $this->exited = match (true) { | ||
| \pcntl_wifsignaled($status) => \pcntl_wtermsig($status), | ||
| \pcntl_wifexited($status) => \pcntl_wexitstatus($status) - 128, | ||
| \pcntl_wifstopped($status) => \pcntl_wstopsig($status), | ||
| default => -1, | ||
| }; | ||
| } | ||
|
|
||
| if (!$this->weKilled && $this->exited > 0) { | ||
| throw new ContextException("Worker exited due to signal {$this->exited}", $this->exited); | ||
| } | ||
|
|
||
| return $this->exited; | ||
| } | ||
|
|
||
| public function close(): void | ||
| { | ||
| if ($this->checkExit(false) === null) { | ||
| $this->weKilled = true; | ||
| \posix_kill($this->pid, \SIGKILL); | ||
|
|
||
| $this->checkExit(true); | ||
| } | ||
|
|
||
| parent::close(); | ||
| } | ||
|
|
||
| public function join(?Cancellation $cancellation = null): mixed | ||
| { | ||
| $result = $this->receiveExitResult($cancellation); | ||
|
|
||
| return $result->getResult(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace Amp\Parallel\Context; | ||
|
|
||
| use Amp\Cancellation; | ||
| use Amp\ForbidCloning; | ||
| use Amp\ForbidSerialization; | ||
| use Amp\Parallel\Ipc\IpcHub; | ||
| use Amp\Parallel\Ipc\LocalIpcHub; | ||
|
|
||
| /** | ||
| * USE AT YOUR OWN RISK! | ||
| * | ||
| * Forking is not recommended at arbitrary points in an application since the entire state of the parent process is | ||
| * inherited into the child process, including the event-loop! | ||
| * | ||
| * We recommend using {@see DefaultContextFactory} or {@see ProcessContextFactory} for general-purpose applications. | ||
| */ | ||
| final class ForkContextFactory implements ContextFactory | ||
| { | ||
| use ForbidCloning; | ||
| use ForbidSerialization; | ||
|
|
||
| /** | ||
| * @param positive-int $childConnectTimeout Number of seconds the child will attempt to connect to the parent | ||
| * before failing. | ||
| * @param IpcHub $ipcHub Optional IpcHub instance. | ||
| */ | ||
| public function __construct( | ||
| private readonly int $childConnectTimeout = 5, | ||
| private readonly IpcHub $ipcHub = new LocalIpcHub(), | ||
| ) { | ||
| } | ||
|
|
||
| /** | ||
| * @param string|non-empty-list<string> $script | ||
| * | ||
| * @throws ContextException | ||
| */ | ||
| public function start(string|array $script, ?Cancellation $cancellation = null): ForkContext | ||
| { | ||
| return ForkContext::start( | ||
| ipcHub: $this->ipcHub, | ||
| script: $script, | ||
| cancellation: $cancellation, | ||
| childConnectTimeout: $this->childConnectTimeout, | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.