Fix missing space between binary and unary operators in reconstruction#275
Open
kkozik-amplify wants to merge 1 commit intorelease/8.xfrom
Open
Fix missing space between binary and unary operators in reconstruction#275kkozik-amplify wants to merge 1 commit intorelease/8.xfrom
kkozik-amplify wants to merge 1 commit intorelease/8.xfrom
Conversation
…truction The reconstructor's _should_add_space_before only checked for binary operator spacing when the next sibling was a Token, but after operators like && the next sibling can be a Tree (expr_term wrapping unary_op), causing "&&!foo" instead of "&& !foo". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
while the parsing issue described in #246 is fixed as of v8.0.0rc2, this PR adds additional reconstruction fix on top of that |
rddimon
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_should_add_space_beforeinHCLReconstructorto add space after binary operator tokens (e.g.&&,||) when the next sibling is a Tree node (e.g.expr_termwrapping aunary_op)&& !foowas reconstructed as&&!foobecause the binary-op spacing logic only handled Token siblings, not Tree siblingsbinary_op_before_unarytest case to the smoke integration suiteTest plan
&& !pattern in for-expression filter conditions&& !contains(...)expressions🤖 Generated with Claude Code