feat(signup): server-driven field collection and interactive prompts for --signup

eslint.config.mjs

@@ -67,7 +67,9 @@ export default tseslint.config(
       'e2e-tests/**/*.ts',
       '**/*.test.js',
       '**/*.test.ts',
+      '**/*.test.tsx',
       '**/__tests__/**/*.ts',
+      '**/__tests__/**/*.tsx',
       '**/__tests__/**/*.js',
       'features/step-definitions/**/*.ts',
     ],

features/13-direct-signup-needs-information.feature

@@ -0,0 +1,84 @@
+Feature: --signup with server-driven field collection
+  As a user running `npx @amplitude/wizard --signup`
+  I want the wizard to send what it has and let the server decide what else
+  is required
+  So that I only get asked for fields the backend actually needs
+
+  # Coverage model. These scenarios exercise the router + session state
+  # transitions that `SigningUpScreen` drives via the store. We don't boot
+  # the TUI or mock HTTP — that layer is covered by router/unit tests. The
+  # BDD here asserts the four user-journey shapes the flow must support:
+  #
+  # 1. --signup only: name → email → signing-up → (needs full_name) → name → signing-up
+  # 2. --signup --email: name → signing-up → (needs full_name) → name → signing-up
+  # 3. --signup + both fields: straight to signing-up (no collection screens)
+  # 4. requires_redirect: signing-up → abandoned → Auth
+  #
+  # "First POST" / "second POST" are represented by the SigningUpScreen
+  # being resolved by the router; the screen's useEffect is what actually
+  # fires `performSignupOrAuth`. We simulate the server response by writing
+  # its effect back onto the session (setSignupRequiredFields / setSignupAuth
+  # / setSignupAbandoned), then re-resolve the router.
+
+  Scenario: --signup with no other flags — two POSTs, two collection screens
+    Given the wizard is started with --signup and no email or full name
+    And the intro is concluded and region is "us"
+    When the router resolves
+    Then it should land on the SignupFullName screen
+    When the user submits the full name "Jane Doe"
+    And the router resolves
+    Then it should land on the SignupEmail screen
+    When the user submits the email "jane@example.com"
+    And the router resolves
+    Then it should land on the SigningUp screen
+    When the first signup POST returns needs_information for "full_name"
+    And the router resolves
+    Then it should land on the SignupFullName screen
+    When the user submits the full name "Jane Doe"
+    And the router resolves
+    Then it should land on the SigningUp screen
+    When the second signup POST returns a success payload
+    And the router resolves
+    Then it should advance past SigningUp to Auth
+
+  Scenario: --signup --email only — one collection screen, two POSTs
+    Given the wizard is started with --signup and email "jane@example.com"
+    And the intro is concluded and region is "us"
+    When the router resolves
+    Then it should land on the SignupFullName screen
+    When the user submits the full name "Jane Doe"
+    And the router resolves
+    Then it should land on the SigningUp screen
+    When the first signup POST returns needs_information for "full_name"
+    And the router resolves
+    Then it should land on the SignupFullName screen
+    When the user submits the full name "Jane Doe"
+    And the router resolves
+    Then it should land on the SigningUp screen
+    When the second signup POST returns a success payload
+    And the router resolves
+    Then it should advance past SigningUp to Auth
+
+  Scenario: --signup with both email and full name — one POST, no collection screens
+    Given the wizard is started with --signup, email "jane@example.com", and full name "Jane Doe"
+    And the intro is concluded and region is "us"
+    When the router resolves
+    Then it should land on the SigningUp screen
+    And the SignupEmail screen should not have been resolved
+    And the SignupFullName screen should not have been resolved
+    When the first signup POST returns a success payload
+    And the router resolves
+    Then it should advance past SigningUp to Auth
+
+  Scenario: requires_redirect — fall through to browser OAuth
+    Given the wizard is started with --signup and email "existing@acme.com"
+    And the intro is concluded and region is "us"
+    When the router resolves
+    Then it should land on the SignupFullName screen
+    When the user submits the full name "Existing User"
+    And the router resolves
+    Then it should land on the SigningUp screen
+    When the first signup POST returns requires_redirect
+    Then session.signupAbandoned becomes true
+    When the router resolves
+    Then it should advance past SigningUp to Auth

features/13-direct-signup-prompts.feature

@@ -0,0 +1,37 @@
+Feature: --signup missing-field prompts in the TUI
+  As a user invoking the wizard with --signup
+  I want the TUI to collect any missing fields (full name, email) before Auth
+  So that I can complete signup without re-running the CLI with extra flags
+
+  # The SignupFullName and SignupEmail screens are injected into the Wizard
+  # flow between RegionSelect and SigningUp (after ToS when required).
+  # They appear only when --signup is set and the corresponding flag was not
+  # supplied on the command line. Once both fields are populated and ToS is
+  # accepted, the router skips collection screens and proceeds to SigningUp.
+
+  Scenario: --signup with no email or full-name prompts for full name first, then email
+    Given the wizard is launched with --signup and no email or full-name
+    And the intro is concluded and region is selected
+    Then the router should resolve to the SignupFullName screen
+    When the user enters their full name
+    Then the router should resolve to the SignupEmail screen
+    When the user enters their email
+    Then the router should resolve to the ToS screen
+    When the user accepts the Terms of Service for direct signup
+    Then the router should resolve to the SigningUp screen
+
+  Scenario: --signup with email supplied but no full-name prompts for full name only
+    Given the wizard is launched with --signup and only an email supplied
+    And the intro is concluded and region is selected
+    Then the router should resolve to the SignupFullName screen
+    When the user enters their full name
+    Then the router should resolve to the ToS screen
+    When the user accepts the Terms of Service for direct signup
+    Then the router should resolve to the SigningUp screen
+
+  Scenario: --signup with all fields supplied goes straight to SigningUp
+    Given the wizard is launched with --signup, email, and full-name all supplied
+    And the intro is concluded and region is selected
+    Then the router should resolve to the SigningUp screen
+    And the SignupFullName screen should be skipped
+    And the SignupEmail screen should be skipped

features/step-definitions/direct-signup-needs-information.steps.ts

@@ -0,0 +1,190 @@
+import { Given, When, Then, Before, After } from '@cucumber/cucumber';
+import assert from 'node:assert';
+import * as fs from 'node:fs';
+import * as os from 'node:os';
+import * as path from 'node:path';
+import { WizardRouter } from '../../src/ui/tui/router.js';
+import { Screen, Flow } from '../../src/ui/tui/flows.js';
+import {
+  buildSession,
+  type WizardSession,
+} from '../../src/lib/wizard-session.js';
+
+// ── Shared state ──────────────────────────────────────────────────────────
+//
+// We mirror the store/router relationship by:
+//   1. Building a session with the flag shape `buildSession` produces for
+//      the given CLI args (signup / signupEmail / signupFullName).
+//   2. Calling router.resolve(session) at each "And the router resolves"
+//      step. Every resolve is recorded in `screensSeen` so we can assert
+//      things like "SignupEmail was never resolved".
+//   3. Simulating the server response by writing its side-effects onto
+//      the session the same way SigningUpScreen does via the store
+//      (setSignupRequiredFields / setSignupAuth / setSignupAbandoned).
+//
+// HTTP is not mocked. The router/session transitions *are* the flow — the
+// SigningUpScreen's POST is triggered by the router mounting that screen,
+// and the flow predicates in `flows.ts` decide what renders next based on
+// what the response wrote back to the session.
+
+let projectDir: string;
+let router: WizardRouter;
+let session: WizardSession;
+let screensSeen: Screen[];
+
+Before(function () {
+  projectDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ampli-signup-test-'));
+  router = new WizardRouter(Flow.Wizard);
+  session = buildSession({ installDir: projectDir });
+  screensSeen = [];
+});
+
+After(function () {
+  fs.rmSync(projectDir, { recursive: true, force: true });
+});
+
+// ── Given ─────────────────────────────────────────────────────────────────
+
+Given(
+  'the wizard is started with --signup and no email or full name',
+  function () {
+    session.accountCreationFlow = true;
+    session.signupEmail = null;
+    session.signupFullName = null;
+  },
+);
+
+Given(
+  'the wizard is started with --signup and email {string}',
+  function (email: string) {
+    session.accountCreationFlow = true;
+    session.signupEmail = email;
+    session.signupFullName = null;
+  },
+);
+
+Given(
+  'the wizard is started with --signup, email {string}, and full name {string}',
+  function (email: string, fullName: string) {
+    session.accountCreationFlow = true;
+    session.signupEmail = email;
+    session.signupFullName = fullName;
+  },
+);
+
+Given(
+  'the intro is concluded and region is {string}',
+  function (region: string) {
+    session.introConcluded = true;
+    session.region = region as WizardSession['region'];
+  },
+);
+
+// ── When ──────────────────────────────────────────────────────────────────
+
+When('the router resolves', function () {
+  const resolved = router.resolve(session);
+  screensSeen.push(resolved);
+});
+
+When('the user submits the email {string}', function (email: string) {
+  // Mirrors store.setSignupEmail — what SignupEmailScreen calls on submit.
+  session.signupEmail = email;
+});
+
+When('the user submits the full name {string}', function (fullName: string) {
+  // Mirrors store.setSignupFullName (trimmed).
+  session.signupFullName = fullName.trim();
+});
+
+When(
+  'the first signup POST returns needs_information for {string}',
+  function (field: string) {
+    // Mirrors what SigningUpScreen does on a needs_information response
+    // with a known, unmet field: store.setSignupRequiredFields([...]),
+    // which both records the requirement and nulls the matching session
+    // value so the flow re-resolves back to the collection screen.
+    session.signupRequiredFields = [field];
+    if (field === 'full_name') {
+      session.signupFullName = null;
+    }
+  },
+);
+
+When('the second signup POST returns a success payload', function () {
+  applySuccess();
+});
+
+When('the first signup POST returns a success payload', function () {
+  applySuccess();
+});
+
+When('the first signup POST returns requires_redirect', function () {
+  // Mirrors SigningUpScreen's response handler on the requires_redirect
+  // arm: setSignupAbandoned(true) so the router falls through to
+  // AuthScreen.
+  session.signupAbandoned = true;
+});
+
+// ── Then ──────────────────────────────────────────────────────────────────
+
+Then('it should land on the SignupEmail screen', function () {
+  const last = screensSeen[screensSeen.length - 1];
+  assert.strictEqual(
+    last,
+    Screen.SignupEmail,
+    `Expected SignupEmail, got ${last}`,
+  );
+});
+
+Then('it should land on the SigningUp screen', function () {
+  const last = screensSeen[screensSeen.length - 1];
+  assert.strictEqual(last, Screen.SigningUp, `Expected SigningUp, got ${last}`);
+});
+
+Then('it should land on the SignupFullName screen', function () {
+  const last = screensSeen[screensSeen.length - 1];
+  assert.strictEqual(
+    last,
+    Screen.SignupFullName,
+    `Expected SignupFullName, got ${last}`,
+  );
+});
+
+Then('it should advance past SigningUp to Auth', function () {
+  const last = screensSeen[screensSeen.length - 1];
+  assert.strictEqual(last, Screen.Auth, `Expected Auth, got ${last}`);
+});
+
+Then('the SignupEmail screen should not have been resolved', function () {
+  assert.ok(
+    !screensSeen.includes(Screen.SignupEmail),
+    `SignupEmail was unexpectedly resolved; saw: ${screensSeen.join(', ')}`,
+  );
+});
+
+Then('the SignupFullName screen should not have been resolved', function () {
+  assert.ok(
+    !screensSeen.includes(Screen.SignupFullName),
+    `SignupFullName was unexpectedly resolved; saw: ${screensSeen.join(', ')}`,
+  );
+});
+
+Then('session.signupAbandoned becomes true', function () {
+  assert.strictEqual(session.signupAbandoned, true);
+});
+
+// ── Helpers ───────────────────────────────────────────────────────────────
+
+function applySuccess(): void {
+  // Mirrors SigningUpScreen's success arm: store.setSignupAuth(result).
+  session.signupAuth = {
+    kind: 'success',
+    idToken: 'id-token',
+    accessToken: 'access-token',
+    refreshToken: 'refresh-token',
+    zone: 'us',
+    userInfo: null,
+    dashboardUrl: null,
+  };
+}