test(checkpoint): bump session-checkpoint timeout to 10s - #250
Merged
Conversation
The loadCheckpoint() tests dynamic-import ./registry.js, which pulls in all 18 framework configs. Under parallel test-runner load this regularly exceeds vitest's default 5s testTimeout, producing intermittent failures across PRs (confirmed reproduces on origin/main, independent of any in-flight branch). Fix is local to the affected describe block via vitest 4.x's options-object syntax. Keeps the change off vitest.config.ts (touched by PR #234) so it doesn't collide with parallel work. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes intermittent timeouts in
src/lib/__tests__/session-checkpoint.test.tsthat have been hitting reviewers across PRs (#241, #243, #244 all observed it; reproduces onorigin/mainindependent of any branch).Root cause: Each
it()doesawait loadCheckpoint(...)which dynamic-imports./registry.js. That import pulls in all 18 framework configs. Under parallel test-runner load it regularly exceeds vitest's default 5stestTimeout.Fix: Set a 10s
timeouton the affected describe block via vitest 4.x's options-object syntax (describe(name, { timeout }, fn)). Surgical — only this describe gets the bigger budget; everything else stays on the default 5s.Why local, not vitest.config.ts
Bumping the global
testTimeoutinvitest.config.tswould also work, but PR #234 already modifies that file. Keeping the fix local to one test file avoids a guaranteed merge conflict and keeps the blast radius minimal.Test plan
pnpm vitest run src/lib/__tests__/session-checkpoint.test.ts— 5 passpnpm vitest run src/__tests__/cli.test.ts src/lib/__tests__/session-checkpoint.test.ts— 38 pass under parallel loadpnpm test— full suite green (1237 passed, 17 skipped)pnpm lint— cleanOut of scope
src/__tests__/cli.test.tsis also intermittently slow under parallel load (its custom 2swaitForpolling helper hits ceilings during full-suite runs), but that file is touched by 4 in-flight PRs (#234, #218, #209, #207). Fixing it now means a guaranteed conflict. Will land separately once those settle.🤖 Generated with Claude Code
Note
Low Risk
Low risk: only adjusts a Vitest test timeout to reduce flaky failures, with no production code changes.
Overview
Reduces flaky timeouts in
src/lib/__tests__/session-checkpoint.test.tsby applying a 10s per-describetimeout via Vitest’s options-object syntax.No behavior assertions were changed; the update is scoped to this suite to accommodate slower
loadCheckpoint()runs that dynamically import the framework registry under parallel test load.Reviewed by Cursor Bugbot for commit d2f8249. Bugbot is set up for automated code reviews on this repo. Configure here.