feat(label): Add alignment and height options#44
Open
marcusorjames wants to merge 2 commits intoamratab:masterfrom
Open
feat(label): Add alignment and height options#44marcusorjames wants to merge 2 commits intoamratab:masterfrom
marcusorjames wants to merge 2 commits intoamratab:masterfrom
Conversation
feat(label): Add alignment and height options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is referencing #39 and #7
I had a similar problem inheriting a codebase that used this library.
A requirement was for the text to be multiline and centered.
Multiline is achieved by multiplying up the height of the
textLayerCentering is achieved by leveraging the
textLayer.alignmentModeI have made these into properties that can be set.
I only needed it for bottom, but added it to top as well. Wasn't where to put center, guessing it might be the default
renderTextIndexes.Comments on variable naming and approach welcome, but thought that it might aid people with the same issue