ci: comment out the iOS native job - #32
Merged
Merged
Conversation
Four `pod lib lint` invocations ran sequentially on a macOS runner and took 81 minutes a run — against 2m17s for the Android equivalent and 50s for the JavaScript checks. The cost is not our code: the four pods are ~2,600 lines of Objective-C between them, but each lint builds an eight-target graph dominated by the Lynx engine and PrimJS, in its own throwaway sandbox, so that compile happened four times per run. Nothing compiles the Objective-C now. `native-contract.test.ts` still pins the native method surfaces against the TypeScript, so a renamed or dropped method is still caught, but a syntax error or a missing header will reach a published tarball — so the docs that claimed CI covered this now say to run `pod lib lint` by hand on a Mac. The job is left commented out rather than deleted, alongside the two fixes worth making before re-enabling it: gate it on the iOS sources changing, and collapse the four lints into one Podfile so Lynx compiles once. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four
pod lib lintinvocations ran sequentially on a macOS runner and took81 minutes a run — against 2m17s for the Android equivalent and 50s for the
JavaScript checks. The cost is not our code: the four pods are ~2,600 lines
of Objective-C between them, but each lint builds an eight-target graph
dominated by the Lynx engine and PrimJS, in its own throwaway sandbox, so
that compile happened four times per run.
Nothing compiles the Objective-C now.
native-contract.test.tsstill pinsthe native method surfaces against the TypeScript, so a renamed or dropped
method is still caught, but a syntax error or a missing header will reach a
published tarball — so the docs that claimed CI covered this now say to run
pod lib lintby hand on a Mac.The job is left commented out rather than deleted, alongside the two fixes
worth making before re-enabling it: gate it on the iOS sources changing, and
collapse the four lints into one Podfile so Lynx compiles once.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
📦 Bundle-size delta vs main (
5ce0ea4→ed05078)Gzipped bytes of each bundled entry (esbuild, minified, browser/es2022, optional peer deps external). Bundling is deterministic, so unlike a timed benchmark these numbers carry no noise and every Δ is exact. ⚪ within ±0.5% · 🟢 smaller · 🔴 larger. Each package's
core (.)must stay flat as subpath features land — that is the whole charter, andsrc/core-size-budget.test.tsholds the absolute ceiling.