prevent print_topics from truncating features#16
Open
alcantarar wants to merge 2 commits intoamueller:mainfrom
Open
prevent print_topics from truncating features#16alcantarar wants to merge 2 commits intoamueller:mainfrom
alcantarar wants to merge 2 commits intoamueller:mainfrom
Conversation
If printing features of varying lengths, especially when ngram > 1, print_topics output was difficult to interpret. Now adjusts topic width to fit longest feature in that topic.
Owner
|
Thanks for the PR. I'm not sure it's worth adding the feature, though. I'll probably get rid of mglean in the next major rewrite. It was never really meant as a practical tool, only as a companion for replicating figures from the book. |
Author
|
No worries, seeing it in sklearn would be neat. |
Owner
|
Feel free to open an issue there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If printing features of varying lengths, especially when ngram > 1, print_topics output was difficult to interpret. Now adjusts topic width to fit longest feature in that topic.