Skip to content

Update Preferences.cpp: Changes location of GeoIP.dat.gz to solve the problem with identifying the flags/countries of users#330

Merged
Vollstrecker merged 1 commit intoamule-project:masterfrom
topotech:master
Feb 24, 2026
Merged

Conversation

@topotech
Copy link
Copy Markdown
Contributor

Changing maintainer and provider of GeoIP.dat.gz in the meantime that other solution appears. This one is from https://mailfud.org/geoip-legacy/. This should fix issue #154

Changing maintainer and provider of GeoIP.dat.gz in the meantime that other solution appears. This one is from https://mailfud.org/geoip-legacy/. This should fix amule-project#154
@topotech topotech changed the title Update Preferences.cpp Update Preferences.cpp: Changes location of GeoIP.dat.gz to solve the problem with identifying the flags/countries of users Apr 21, 2022
@minnyres
Copy link
Copy Markdown

It may not work since aMule does not have https support.

@topotech
Copy link
Copy Markdown
Contributor Author

It may not work since aMule does not have https support.

Oh. Then you're right, it's almost sure it won't work if that's really the case. Wget shows the web server has a strict transport security policy.


$ wget http://mailfud.org/geoip-legacy/GeoIP.dat.gz
URL transformed to HTTPS due to an HSTS policy
--2022-04-25 01:21:55--  https://mailfud.org/geoip-legacy/GeoIP.dat.gz
...

@minnyres
Copy link
Copy Markdown

Oh. Then you're right, it's almost sure it won't work if that's really the case. Wget shows the web server has a strict transport security policy.

Nevertheless, it may work with this patch: #218.
I will make a test with it.

@minnyres
Copy link
Copy Markdown

minnyres commented May 5, 2022

Nevertheless, it may work with this patch: #218. I will make a test with it.

It's a good news that aMule can update ipfilter from https://mailfud.org/geoip-legacy/ if built with libcurl.
There is one more problem. This patch only sets the default address of ipfilter. If there is already a configuration file amule.conf, aMule will still use the address http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz in the file.

@topotech
Copy link
Copy Markdown
Contributor Author

topotech commented May 6, 2022

I know, but after thinking about it for some time, I think it isn't a bad thing, because effectively someone could want a different server. I don't think it's bad this fix only works for new users.

@minnyres
Copy link
Copy Markdown

minnyres commented May 7, 2022

I don't think it's bad this fix only works for new users.

Yeah, old users may already have a geoip data file.

@Vollstrecker Vollstrecker merged commit a7bd265 into amule-project:master Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants