Selected lines in Download/Shared lists become illegible when losing focus

[danim7]

In several lists across amule, a selected line that loses focus becomes illegible because it is drawn with a white text on a white background.

There are a couple of ways to reproduce it: It happens when right-clicking on a line in the list. It also happens when selecting a line in the downloads/shared list (upper side of the window), and then clicking a line in the secondary list about clients (bottom side of the window).

The affected windows are: Downloads and Shared.
The Search window is not affected by this issue.
When comparing them, all of them use the same colour scheme, but the affected classes are using a Blend() on the colours, while the unaffected class isn't. The proposed change is to remove the Blend() on the colours from the affected classes.

Attaching a couple of screenshots before and after the fix.

The test environment has been Ubuntu 24.04, compiling the last version from master with wxWidgets 3.2.4 and boost 1.83.

Before: the third line is selected in the upper list, but when clicking on a peer in the bottom list, the line becomes illegible:

After: a line is selected in the upper list, and when clicking on a peer in the bottom list, the line can still be read:

[Vollstrecker]

Looks OK, but your commit message says remove but you just comented them.

Could you really remove them?

[danim7]

Oh, i was rebasing the branch, but i haven't made your requested change yet... is it ok if now is merged as commented code instead of fully removing it?

[Vollstrecker]

Sorry, I had some PR's in mind that had just conflicts and have been to fast.