Docker file is added#414
Open
shraddha761 wants to merge 1 commit intoamupedia2021:masterfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you, @shraddha761, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
Contributor
Author
|
@anmode please have a look |
anmode
requested changes
Jun 13, 2023
Member
anmode
left a comment
There was a problem hiding this comment.
Please attach the build image size , and image details with successful build
Comment on lines
+1
to
+11
| FROM node:slim | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY . /app | ||
|
|
||
| RUN npm install | ||
|
|
||
| EXPOSE 3000 | ||
|
|
||
| CMD npm start |
Member
There was a problem hiding this comment.
can you copy only build files at last? Do use multistage build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue reference - #160
Please provide a brief description of the changes introduced in this pull request. Explain the problem you are solving or the feature you are adding.
Pull Request Checklist
Please make sure that your PR meets the following requirements:
Checklist
Please check all applicable boxes and provide any additional information if needed.
Screenshots - If Any (Optional)
Additional Notes(Optional)
Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
Please tag the relevant team members or reviewers who should review this pull request.