Add IonClobAttribute#75
Open
PlasmaIntec wants to merge 1 commit intomainfrom
Open
Conversation
PlasmaIntec
commented
Jan 14, 2022
| /// </summary> | ||
| /// | ||
| /// <param name="encoding">Type of encoding for Clob.</param> | ||
| public IonClobSerializer(string encodingString = "Unicode") |
Contributor
Author
There was a problem hiding this comment.
The reason IonClobSerializer takes a string rather than a Encoding is because in C#, Only primitive constants or arrays of primitives can be used as attribute parameters
Contributor
There was a problem hiding this comment.
could we consider to use enum instead of string? and enum supports switch expression
Contributor
guyilin-amazon
left a comment
guyilin-amazon
left a comment
There was a problem hiding this comment.
- There are some check warnings need to be fixed
- The specification and changelog also need to be updated
| /// </summary> | ||
| /// | ||
| /// <param name="encoding">Type of encoding for Clob.</param> | ||
| public IonClobSerializer(string encodingString = "Unicode") |
Contributor
There was a problem hiding this comment.
could we consider to use enum instead of string? and enum supports switch expression
| * and limitations under the License. | ||
| */ | ||
|
|
||
| namespace Amazon.IonObjectMapper.Demo |
Contributor
There was a problem hiding this comment.
this file should be put into demo project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
73
Description of changes:
Add IonClobAttribute which takes an encoding so customers can specify which string properties should be converted to an Ion Clob instead of an Ion String.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.