Mxfe sync zc706/zcu102 by ranechita · Pull Request #3009 · analogdevicesinc/no-OS

ranechita · 2026-03-19T11:01:02Z

Pull Request Description

Modify ad9081 and hmc7044 to enable support for multi-chip sync and update the project accordingly.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

Check if SYNC occurred during synchronizing using EXT SYNC. Signed-off-by: George Mois <george.mois@analog.com>

ranechita · 2026-03-20T11:13:36Z

v2:

added README documentation for mcs_gpio

ranechita · 2026-03-20T11:46:57Z

v3:

fix typo in documentation commit description
add mcs gpio initilization example
remove unrelated change from Makefile

ranechita · 2026-03-20T12:54:04Z

v4:

added mcs to drivers_doc.rst

buha · 2026-03-23T07:30:41Z

Documentation still errors out:

ERROR: New component 'mcs_gpio.c' in 'drivers' is missing README.rst file
Please add a README.rst file at: drivers/mcs/mcs_gpio.c/README.rst

amiclaus

when adding new drivers you need to follow the standard pattern. drivers/category/driver_name/ this should fix the doc build. on the other hand wondering if we should place or not the mcs under jesd204.

amiclaus · 2026-03-23T08:07:33Z

 	/* NCO Sync */
+	if (phy->l_f_sync && phy->leader) {
+		do {
+			ret = no_os_gpio_get_value(phy->lf_input_pin, &val);


infinite loop?

amiclaus · 2026-03-23T08:07:39Z

+		ret = no_os_gpio_set_value(phy->lf_output_pin, 1);
+	if (phy->l_f_sync && !phy->leader)
+		do {
+			ret = no_os_gpio_get_value(phy->lf_input_pin, &val);


amiclaus · 2026-03-23T08:08:03Z

 	if (ret != 0)
 		return ret;
+	if (phy->lf_output_pin)
+		ret = no_os_gpio_set_value(phy->lf_output_pin, 1);


ret is overwritten below.

amiclaus · 2026-03-23T08:08:28Z

+
+	ret = no_os_gpio_get(&dev->gpio_req, init_param->gpio_req);
+	if (ret < 0)
+		return ret;


amiclaus · 2026-03-23T08:08:41Z

+	if (ret < 0)
+		return ret;
+	if (dev->gpio_req)
+		no_os_gpio_direction_output(dev->gpio_req, 0);


return not handled.

amiclaus · 2026-03-23T08:10:55Z

+					pr_err("Error reading alarm status.\n");
+					return ret;
+				}
+				if (!HMC7044_SYSREF_SYNC_STAT(val))


no timeout?

amiclaus · 2026-03-23T08:11:36Z

+	pr_debug("%s:%d reason %s\n", __func__, __LINE__,
+		 jesd204_state_op_reason_str(reason));
+
+	no_os_gpio_set_value(mcs_gpio->gpio_req, 1);


return values no handled.

amiclaus · 2026-03-23T08:12:19Z

+        };
+
+	status = mcs_gpio_init(&mcs_dev, &mcs_gpio_init_params);
+        if (status) {


odd indentation

amiclaus · 2026-03-23T08:12:35Z

+MCS_GPIO Driver Initialization Example
+--------------------------------------
+
+.. code-block:: bash


this should be .. code-block:: c

amiclaus · 2026-03-23T08:12:55Z

+#ifdef MCS_CONTINUOUS_SYSREF
+	status = mcs_gpio_init(&mcs_dev, &mcs_gpio_init_params);
+	if (status)
+		printf("mcs_gpio_init() error: %" PRId32 "\n", status);


we continue if errors occur?

ranechita · 2026-03-23T09:15:37Z

when adding new drivers you need to follow the standard pattern. drivers/category/driver_name/ this should fix the doc build. on the other hand wondering if we should place or not the mcs under jesd204.

Do you mean the jesd204 folder in drivers/axi_core ? I think it might be confusing because the driver has nothing to do with axi. If you mean no-OS/jesd204 I don't think it would be appropriate because it contains only fsm and core and nothing driver related imo.

There's also the possibility of putting the mcs driver in util or maybe a new folder util/jesd204?

amiclaus · 2026-03-23T11:04:36Z

There's also the possibility of putting the mcs driver in util or maybe a new folder util/jesd204?

Yep, makes sense.

Add leader-follower synchronization logic. Signed-off-by: George Mois <george.mois@analog.com>

Add the driver for a MCS GPIO device that can be part of a JESD topology. Signed-off-by: George Mois <george.mois@analog.com>

ranechita · 2026-03-25T10:13:44Z

v5:

added timeout to the gpio loops in ad9081
handled return codes and addresses memleaks in mcs_gpio
fixed indentation and .. code-block:: bash in README
moved mcs_gpio driver and readme in separate folder inside mcs
returned with error when mcs_gpio_init does not succeed in app.c
updated path in driver_doc.rst for mcs_gpio

Add short documentation for mcs_gpio. Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>

Add options for leader-follower single MxFE synchronization. Add the MCS GPIO to the JESD topology for leader-follower MxFE synchronization. Added a MCS_CONTINUOUS_SYSREF variable for the MXFE sync use case. Signed-off-by: George Mois <george.mois@analog.com>

drivers: frequency: hmc7044: External sync

56a7e24

Check if SYNC occurred during synchronizing using EXT SYNC. Signed-off-by: George Mois <george.mois@analog.com>

ranechita requested review from CiprianRegus, RaduSabau1, amiclaus, buha, cristina-suteu, danmois, dbogdan, raezt, ralucabozdog, rbolboac, rbudai98 and stefpopa as code owners March 19, 2026 11:01

github-actions Bot added drivers projects labels Mar 19, 2026

ranechita self-assigned this Mar 19, 2026

ranechita force-pushed the mxfe_sync_zc706 branch 2 times, most recently from 8689c8a to 668d8f5 Compare March 20, 2026 11:08

github-actions Bot added the documentation label Mar 20, 2026

danmois previously approved these changes Mar 20, 2026

View reviewed changes

buha reviewed Mar 20, 2026

View reviewed changes

Comment thread drivers/mcs/mcs_gpio/README.rst

buha reviewed Mar 20, 2026

View reviewed changes

Comment thread projects/ad9081/Makefile Outdated

ranechita dismissed danmois’s stale review via e57d34c March 20, 2026 11:44

ranechita force-pushed the mxfe_sync_zc706 branch from 668d8f5 to e57d34c Compare March 20, 2026 11:44

ranechita force-pushed the mxfe_sync_zc706 branch from e57d34c to f9363fb Compare March 20, 2026 11:49

buha previously approved these changes Mar 20, 2026

View reviewed changes

ranechita dismissed buha’s stale review via 2c5f38e March 20, 2026 12:50

ranechita force-pushed the mxfe_sync_zc706 branch from f9363fb to 2c5f38e Compare March 20, 2026 12:50

danmois previously approved these changes Mar 23, 2026

View reviewed changes

amiclaus reviewed Mar 23, 2026

View reviewed changes

danmois added 2 commits March 25, 2026 11:26

drivers: adc: ad9081: Add leader-follower sync

bf636e3

Add leader-follower synchronization logic. Signed-off-by: George Mois <george.mois@analog.com>

drivers: mcs: Add MCS GPIO as JDEV

244f20d

Add the driver for a MCS GPIO device that can be part of a JESD topology. Signed-off-by: George Mois <george.mois@analog.com>

ranechita dismissed danmois’s stale review via 1597b60 March 25, 2026 10:11

ranechita force-pushed the mxfe_sync_zc706 branch from 2c5f38e to 1597b60 Compare March 25, 2026 10:11

ranechita and others added 2 commits March 25, 2026 14:33

drivers: mcs: Add README for mcs_gpio

0891b46

Add short documentation for mcs_gpio. Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>

ranechita force-pushed the mxfe_sync_zc706 branch from 1597b60 to d8ee68e Compare March 25, 2026 12:33

amiclaus approved these changes Mar 25, 2026

View reviewed changes

buha merged commit ccd42f8 into main Mar 30, 2026
17 of 19 checks passed

buha deleted the mxfe_sync_zc706 branch March 30, 2026 12:12

Conversation

ranechita commented Mar 19, 2026

Pull Request Description

PR Type

PR Checklist

Uh oh!

ranechita commented Mar 20, 2026

Uh oh!

Uh oh!

Uh oh!

ranechita commented Mar 20, 2026

Uh oh!

ranechita commented Mar 20, 2026

Uh oh!

buha commented Mar 23, 2026

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ranechita commented Mar 23, 2026

Uh oh!

amiclaus commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ranechita commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amiclaus commented Mar 23, 2026 •

edited

Loading

ranechita commented Mar 25, 2026 •

edited

Loading