Skip to content

🎨 Palette: Add accessible aria-label to settings navigation link#953

Open
anchapin wants to merge 3 commits intomainfrom
palette-settings-accessible-link-320742299427355609
Open

🎨 Palette: Add accessible aria-label to settings navigation link#953
anchapin wants to merge 3 commits intomainfrom
palette-settings-accessible-link-320742299427355609

Conversation

@anchapin
Copy link
Copy Markdown
Owner

@anchapin anchapin commented Apr 3, 2026

  • 💡 What: Added an aria-label to the settings icon link in the top navigation, and wrapped the visual emoji with <span aria-hidden="true">.
  • 🎯 Why: This improves accessibility for screen readers by providing a descriptive label instead of reading the emoji character out loud.
  • 📸 Before/After: Visual changes are not applicable, this is a screen reader accessibility change.
  • ♿ Accessibility: The screen reader will now read "Settings" instead of "Gear" for the settings navigation link.

PR created automatically by Jules for task 320742299427355609 started by @anchapin

Summary by Sourcery

Improve accessibility of the top navigation settings link by providing a descriptive ARIA label and hiding the decorative emoji from assistive technologies.

Enhancements:

  • Add an ARIA label to the settings navigation link so screen readers announce it as “Settings” instead of reading the emoji.
  • Mark the settings gear emoji as aria-hidden to treat it as purely decorative for assistive technologies.

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings April 3, 2026 00:09
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an accessible aria-label to the settings navigation link and updates the top navigation links config and rendering logic to support optional aria labels for links.

Flow diagram for TopNavigation link configuration with optional ariaLabel

flowchart TD
  A[TopNavigation_component] --> B[Define_navigationLinks_array]
  B --> C[Link_home_to_/]
  B --> D[Link_experiments_to_/experiments]
  B --> E[Link_results_to_/experiment-results]
  B --> F[Link_docs_to_/docs]
  B --> G[Link_settings_to_/settings_with_label_span_aria-hidden_true_and_ariaLabel_Settings]

  H[Render_navigation_links] --> I[Iterate_over_navigationLinks]
  I --> J[For_each_link_create_Link_component]
  J --> K[Set_Link_to_property_from_link_to]
  J --> L[Set_Link_content_from_link_label]
  J --> M[Set_optional_aria-label_from_link_ariaLabel]

  A --> H
  B --> H
Loading

File-Level Changes

Change Details Files
Add support for optional aria-labels on top navigation links and apply it to the settings link with a hidden gear emoji icon.
  • Extend navigationLinks items to optionally include an ariaLabel field in addition to to and label
  • Wrap the visual gear emoji for the settings link in a span with aria-hidden="true" so it is ignored by screen readers
  • Provide an ariaLabel of "Settings" for the settings navigation link for screen readers
  • Update the navigationLinks map callback to destructure ariaLabel and pass it through as the Link aria-label attribute
frontend/src/components/TopNavigation/TopNavigation.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider updating the type definition for navigationLinks (and any related props/interfaces) so that label can be a ReactNode and ariaLabel is explicitly typed as an optional string, which will make this pattern clearer and prevent implicit any usage.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider updating the type definition for `navigationLinks` (and any related props/interfaces) so that `label` can be a `ReactNode` and `ariaLabel` is explicitly typed as an optional string, which will make this pattern clearer and prevent implicit `any` usage.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the accessibility of the Top Navigation settings link by ensuring screen readers announce a meaningful name (“Settings”) instead of reading the gear emoji.

Changes:

  • Replaced the settings link’s emoji-only label with an emoji wrapped in aria-hidden="true".
  • Added an explicit aria-label="Settings" for the settings navigation link while leaving other links unchanged.

google-labs-jules bot and others added 2 commits April 3, 2026 00:45
Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants