Skip to content

⚡ Bolt: Optimize regex compilation in job_parser#233

Open
anchapin wants to merge 1 commit intomainfrom
bolt-optimize-regex-job-parser-2187414884248275475
Open

⚡ Bolt: Optimize regex compilation in job_parser#233
anchapin wants to merge 1 commit intomainfrom
bolt-optimize-regex-job-parser-2187414884248275475

Conversation

@anchapin
Copy link
Copy Markdown
Owner

@anchapin anchapin commented Apr 6, 2026

⚡ Bolt: Optimize regex compilation in job_parser

💡 What: Moved regex patterns for _extract_salary_from_text, _extract_job_type, and _extract_experience_level to pre-compiled module-level constants.
🎯 Why: To prevent recompiling identical regular expressions on every parsing iteration and reduce allocations on a performance hotpath for ATS applications.
📊 Impact: Reduces parser execution overhead by caching compiled states, enabling faster processing.
🔬 Measurement: python -m pytest tests/test_job_parser_integration.py successfully validates that all logic rules and cases function as expected with the new constant-based patterns.


PR created automatically by Jules for task 2187414884248275475 started by @anchapin

Summary by Sourcery

Precompile common regex patterns in the job parser to avoid repeated compilation on each parse.

Enhancements:

  • Introduce module-level precompiled regex lists for salary, job type, and experience level extraction to reduce runtime overhead.
  • Allow the text extraction helper to accept both string and precompiled regex patterns for more efficient matching.

Identified a performance bottleneck in `cli/integrations/job_parser.py` where regex patterns for extracting salary, job type, and experience level were being repeatedly compiled on every parse operation.

Optimized the performance by moving `re.compile` patterns for salaries, job types, and experience levels into module-level lists (`_SALARY_PATTERNS`, `_JOB_TYPE_PATTERNS`, `_EXPERIENCE_LEVEL_PATTERNS`) preventing redundant compilation on hot paths. Updated type hint in `_extract_text_by_pattern` to support `Union[str, re.Pattern]`. Tests and linting confirm safety and correctness of the change.

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 6, 2026

Reviewer's Guide

This PR optimizes the job parser by hoisting several frequently used regex patterns to pre-compiled module-level constants and updating the extraction helpers to use these compiled patterns while preserving existing parsing behavior and test coverage.

Class diagram for updated job_parser regex structure

classDiagram
    class JobParserModule {
        <<module>>
        re.Pattern[] _SALARY_PATTERNS
        re.Pattern[] _JOB_TYPE_PATTERNS
        re.Pattern[] _EXPERIENCE_LEVEL_PATTERNS
    }

    class JobParser {
        +_extract_text_by_pattern(text: str, pattern: Union[str, re.Pattern]) Optional[str]
        +_extract_salary_from_text(text: str) Optional[str]
        +_extract_job_type(html: str) Optional[str]
        +_extract_experience_level(html: str) Optional[str]
    }

    JobParserModule <.. JobParser : uses

    JobParser ..> re.Pattern : pattern_search
Loading

Flow diagram for optimized salary extraction with precompiled regex

flowchart TD
    A[Start _extract_salary_from_text] --> B[Input text]
    B --> C[Set iterator over _SALARY_PATTERNS]
    C --> D{More patterns?}
    D -- Yes --> E[Get next precompiled pattern]
    E --> F[pattern.search on text]
    F --> G{Match found?}
    G -- Yes --> H[Determine salary from group 0 or 1]
    H --> I[Clean salary string]
    I --> J[Return cleaned salary]
    G -- No --> D
    D -- No --> K[Return None]
    J --> L[End]
    K --> L[End]
Loading

File-Level Changes

Change Details Files
Pre-compile common salary, job type, and experience-level regex patterns at module scope and use them in the corresponding extractor methods to avoid repeated compilation on each call.
  • Introduce _SALARY_PATTERNS, _JOB_TYPE_PATTERNS, and _EXPERIENCE_LEVEL_PATTERNS lists of compiled regex objects configured with re.IGNORECASE.
  • Refactor _extract_salary_from_text to iterate over _SALARY_PATTERNS and use pattern.search instead of re.search with a raw pattern string and flags.
  • Refactor _extract_job_type and _extract_experience_level to iterate over their respective compiled pattern lists and use pattern.search on the HTML input.
cli/integrations/job_parser.py
Generalize the regex extraction helper to accept both raw pattern strings and pre-compiled regex Pattern objects, enabling a gradual migration to compiled patterns without breaking existing callers.
  • Update _extract_text_by_pattern signature to accept Union[str, re.Pattern].
  • Add isinstance(pattern, re.Pattern) branching to call pattern.search when pre-compiled, otherwise fall back to re.search with re.IGNORECASE.
  • Keep the existing group(1).strip() behavior to maintain output shape for existing call sites.
cli/integrations/job_parser.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since _SALARY_PATTERNS, _JOB_TYPE_PATTERNS, and _EXPERIENCE_LEVEL_PATTERNS are intended as constants, consider making them tuples instead of lists to better communicate immutability and avoid accidental modification.
  • In both _extract_job_type and _extract_experience_level, match.group(1).lower().replace("-", "-") is a no-op; if the intent is to normalize hyphens (e.g., to a space or empty string), update the replacement accordingly or remove it for clarity.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `_SALARY_PATTERNS`, `_JOB_TYPE_PATTERNS`, and `_EXPERIENCE_LEVEL_PATTERNS` are intended as constants, consider making them tuples instead of lists to better communicate immutability and avoid accidental modification.
- In both `_extract_job_type` and `_extract_experience_level`, `match.group(1).lower().replace("-", "-")` is a no-op; if the intent is to normalize hyphens (e.g., to a space or empty string), update the replacement accordingly or remove it for clarity.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant