Skip to content

⚡ Bolt: [performance improvement] Pre-compile regex patterns in keyword density#245

Open
anchapin wants to merge 1 commit intomainfrom
bolt-regex-precompile-12955798762256913752
Open

⚡ Bolt: [performance improvement] Pre-compile regex patterns in keyword density#245
anchapin wants to merge 1 commit intomainfrom
bolt-regex-precompile-12955798762256913752

Conversation

@anchapin
Copy link
Copy Markdown
Owner

@anchapin anchapin commented Apr 12, 2026

💡 What: Moved title_patterns and company_patterns regular expressions from within _extract_job_details to the module level as pre-compiled regex objects (_TITLE_PATTERNS and _COMPANY_PATTERNS).
🎯 Why: To avoid repeated regex parsing and compilation on every execution of _extract_job_details, which runs for every parsed job description. This removes unneeded overhead.
📊 Impact: Minor processing time reduction for keyword density analysis. Removing compiling from a loop/function is a standard performance best practice in Python.
🔬 Measurement: Running the test suite (python -m pytest tests/test_keyword_density.py) confirms no breakage in the keyword matching and logic extraction behavior.


PR created automatically by Jules for task 12955798762256913752 started by @anchapin

Summary by Sourcery

Enhancements:

  • Move job title and company extraction regexes to module-level pre-compiled patterns for more efficient reuse in _extract_job_details.

Moved the title and company extraction regex patterns out of the loop and pre-compiled them at the module level. This prevents them from being compiled repeatedly every time the `_extract_job_details` function is called, yielding a minor performance win.

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pre-compiles the regex patterns used to extract job title and company from job descriptions in keyword_density.py to avoid recompilation on each function call, while updating the extraction logic to use these compiled patterns.

File-Level Changes

Change Details Files
Pre-compile job title extraction regexes at module level and update extraction logic to use them.
  • Introduce a module-level _TITLE_PATTERNS list containing compiled regex objects for common job title patterns.
  • Remove the local title_patterns list of raw regex strings within _extract_job_details.
  • Change the title extraction loop to iterate over _TITLE_PATTERNS and call pattern.search(job_description) without passing flags each time.
cli/utils/keyword_density.py
Pre-compile company name extraction regexes at module level and update extraction logic to use them.
  • Introduce a module-level _COMPANY_PATTERNS list containing compiled regex objects for common company name patterns.
  • Remove the local company_patterns list of raw regex strings within _extract_job_details.
  • Change the company extraction loop to iterate over _COMPANY_PATTERNS and call pattern.search(job_description) without passing flags each time.
cli/utils/keyword_density.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant