Adding container-storage as a provider for daemonless Podman and Buildah Support#635
Open
Bru456 wants to merge 4 commits into
Open
Adding container-storage as a provider for daemonless Podman and Buildah Support#635Bru456 wants to merge 4 commits into
Bru456 wants to merge 4 commits into
Conversation
…rage such as on podman and buildah. This is to implement issue anchore#197 Signed-off-by: Bruce Clark <bruce.clark@mandg.com>
Signed-off-by: Bruce Clark <bruce.clark@mandg.com>
…lity Signed-off-by: Bruce Clark <bruce.clark@mandg.com>
Signed-off-by: Bruce Clark <bruce.clark@mandg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Podman daemonless and buildah support to stereoscope for issue #197 and Syft issue 2107: Add support for containers-storage backend for container images
This feature adds:
containerstorage:containers/imageand delegates to the existing docker archive provider.tags,os,architecture, andvariantis populated.containers-storageto allow for either auto detection or explicit usage via--from containers-storagedaemon->containers-storage->remote registry. Allowing locally built images to resolve before a remote pull.Build
I have added a build tag to allow the inclusion of the new provider. It is excluded by default via a stub saying it hasn't been compiled in. tag:
containers_image_openpgp.Dependency management
Pulled in
containers/image/v5+containers/storage. Linux builds also useexclude_graphdriver_btrfs/exclude_graphdriver_devicemapper.Pinned
filepath-securejoinandselinuxvia go.mod replaces to resolve a conflict betweencontainers/storageandcontainerd/hcsshimrequirements.Tests
New unit tests are in and passing.
Tested compiling for both Linux and non Linux builds and bundling this with a local copy of the latest Syft. Docker, Podman (daemon and daemonless) and buildah all working and creating consistent SBOMs. Compared with Syft v1.46.0
previous-syft-json-sboms.zip
and new version with stereoscope
new-syft-json-sboms.zip
Issues encountered and fixes
securejoin/selinuxversion conflict (Linux):containers/storage v1.59.1calls root-levelsecurejoin.OpenInRoot/Reopen, which only exist infilepath-securejoin v0.4.x.containerd v2/hcsshimpullv0.6.0(where those moved intopathrs-lite), andselinux v1.13.1transitively drags in the newer requirement.securejoin v0.4.1,selinux v1.12.0), which keeps both ecosystems building together.