Add response headers to head results - #46
Open
toots wants to merge 1 commit into
Open
Conversation
andersfugmann
left a comment
andersfugmann
left a comment
Owner
There was a problem hiding this comment.
Overall looks good. I have a couple of questions and suggestions that I'd like your comments on.
head now returns the object's headers as content.response_headers, with find_header to look one up without minding the case the server chose, which covers content-type and anything else the API does not model. ls parses an xml listing that carries no per-object headers, so the field is None there rather than an empty list.
toots
changed the title
Author
|
Comments addressed @andersfugmann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
headnow returns the object's headers ascontent.response_headers, withfind_headerto look one up without minding the case the server chose, which coverscontent-typeand anything else the API does not model.lsparses an xml listing that carries no per-object headers, so the field isNonethere rather than an empty list.