Skip to content

#2 Fix Dark Mode toggle button text not updating after mode switch"#5

Open
omjadhav18 wants to merge 4 commits into
andoriyaprashant:mainfrom
omjadhav18:ToggleButtonBug
Open

#2 Fix Dark Mode toggle button text not updating after mode switch"#5
omjadhav18 wants to merge 4 commits into
andoriyaprashant:mainfrom
omjadhav18:ToggleButtonBug

Conversation

@omjadhav18
Copy link
Copy Markdown

This PR fixes the issue where the "Dark Mode" toggle button text remained static, always showing "Dark Mode" even after switching to dark mode. The button text now dynamically updates to reflect the current mode, displaying "Light Mode" when dark mode is enabled and "Dark Mode" when it is disabled.
Screenshot 2024-10-01 201213
Screenshot 2024-10-01 201248

Changes:

  1. Added logic to the toggleDarkMode() function to dynamically update the button text based on the current mode (dark/light).
  2. the button text changes appropriately whenever the dark mode is toggled, improving the user experience.

Issue Fixed: Closes [issue #2] - "Dark Mode toggle button text does not update to reflect current mode."

@thestuti
Copy link
Copy Markdown
Collaborator

thestuti commented Oct 2, 2024

Thank you for your PR! Could you please change the href text color to something that enhances the UI for dark mode? This will help improve the overall readability and aesthetics. Thanks!

@omjadhav18
Copy link
Copy Markdown
Author

Yes

@thestuti
Copy link
Copy Markdown
Collaborator

thestuti commented Oct 2, 2024

Please request for review after the changes.

@omjadhav18
Copy link
Copy Markdown
Author

omjadhav18 commented Oct 3, 2024

Yes

@omjadhav18
Copy link
Copy Markdown
Author

Change the href text color now it looks good in dark and light mode now.
I also added a hover effect while hovering the on href links.
Screenshot 2024-10-03 161735
Screenshot 2024-10-03 161709

@omjadhav18
Copy link
Copy Markdown
Author

please add the label gssoc and hactoberfest .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants