Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a file with statements to execute to trigger precompilation. Julia v1.8 has gotten a number of improvements to the ability of caching precompiled code, making this potentially worthwhile. The benchmark below shows that the snippet
goes from taking 11.7 seconds to run the first time to taking 6.7 seconds with precompilation. The price to pay for this is that the precompilation itself takes longer time, indicated below. Precompilation only happens once though, and does then not happen again until MatrixEquations.jl is updated. This is thus likely a good trade-off for end users. Developers of this package, however, might have to pay the precompilation time repeatedly, making the trade-off significantly worse. This PR thus only performs the precompilation if the package is not checked out for development. Developers will thus not see any difference from this PR.
I only added a small number of statements to the precompilation file, more statements can be added at the expense of longer precompilation times. The best trade-off is likely achieved by including calls to core routines that are used by many other functions.