Skip to content

fix(action): implement potential fixes for 4 code quality findings from GitHub #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MFHellscapes merged 6 commits into from
Jun 13, 2026
Merged

fix(action): implement potential fixes for 4 code quality findings from GitHub #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d6b22b
Apply suggested fix to action.js from Copilot Autofix
ajhalili2006 Jun 13, 2026
88f873b
Apply suggested fix to action.js from Copilot Autofix
ajhalili2006 Jun 13, 2026
5ec2ad6
Apply suggested fix to action.js from Copilot Autofix
ajhalili2006 Jun 13, 2026
8bf761b
Apply suggested fix to action.js from Copilot Autofix
ajhalili2006 Jun 13, 2026
a7dfa66
fix(action): fix log grouping related issue
ajhalili2006 Jun 13, 2026
1af9bda
chore(action): update logging and sync dist files
ajhalili2006 Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions action.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ function getBoolInputEnv() {

if (trueValue.includes(bool)) return true;
if (falseValue.includes(bool)) return false;

core.warning(
`Invalid value for INPUT_INJECT_ENV_VARS: "${bool}". Expected one of true/false. Falling back to false.`,
);
return false;
Comment thread
ajhalili2006 marked this conversation as resolved.
Comment thread
ajhalili2006 marked this conversation as resolved.
}

const opts = {
Expand All @@ -26,9 +31,8 @@ const opts = {
injectVars: getBoolInputEnv(),
};

core.group("options debug", async () => {
await core.group("options debug", async () => {
core.debug(JSON.stringify(opts, null, 2));
core.endGroup();
});

/* Placeholder object for parsed secrets after decryption */
Expand All @@ -47,19 +51,24 @@ if (opts.key) {
dotenv.config({
path: opts.path,
processEnv: dotenvPlain,
debug: core.isDebug() ? true : false,
debug: core.isDebug(),
});
dotenvx.config({
path: opts.path,
processEnv: secretsTmp,
debug: core.isDebug() ? true : false,
debug: core.isDebug(),
});

Object.keys(secretsTmp).forEach((key) => {
const value = secretsTmp[key];

// warn user on failed-to-encrypt secrets
if (value.startsWith("encrypted:")) {
const plainValue = dotenvPlain[key];
const isEncryptedValue =
Comment thread
ajhalili2006 marked this conversation as resolved.
typeof value === "string" && value.startsWith("encrypted:");
const isEncryptedPlainValue =
typeof plainValue === "string" && plainValue.startsWith("encrypted:");

// warn user on failed-to-decrypt secrets
if (isEncryptedValue) {
core.warning(
`decryption failed for key ${key}, check your inputs/secrets if key is correct`,
);
Expand All @@ -68,10 +77,7 @@ Object.keys(secretsTmp).forEach((key) => {
}

// Automatically mask decrypted secrets when prefixed with "encrypted:" using plain old dotenv package
if (
dotenvPlain[key].startsWith("encrypted:") &&
!secretsTmp[key].startsWith("encrypted:")
) {
if (isEncryptedPlainValue && !isEncryptedValue) {
core.setSecret(value);
}

Expand Down
Loading
Loading