Add the Parse and TryParse static methods#85
Add the Parse and TryParse static methods#85lucasteles wants to merge 3 commits intoandrewlock:masterfrom
Conversation
|
Looks great. Are you sure that |
|
@hankovich no I don't 😅, It looked correct to me at first, usually it's undesired spaces at edges of the strings Wdyt? |
|
@lucasteles I think If trimming will be added, it makes sense to trim in constructors, not inside parsing methods. And I'm not sure everyone needs they input to be trimmed |
|
Makes sense to me, I will update the the PR |
|
@hankovich updated |
|
Thank you, @lucasteles ! I thought I must be using this library wrong since I have to manually add the static @andrewlock , any chance of getting this or something similar merged into the release? |
I implemented it in my fork |
Add the
.Parseand.TryParsestatic methods on all base templates.They are common and expected methods for value types.
.TryParseis especially good because enables the use of custom types on ASP.NET Minimal Api routesfix #30