Update to support requirejs in the browser, no functional changes#25
Open
owenallenaz wants to merge 1 commit into
Open
Update to support requirejs in the browser, no functional changes#25owenallenaz wants to merge 1 commit into
owenallenaz wants to merge 1 commit into
Conversation
Owner
|
Why is this required? I've been using this module in the browser for years without this boilerplate. |
Author
|
If you are using this in the browser you must be wrapping it or copy-pasting it into a different file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps the existing diacritic index.js in a UMD boilerplate from https://github.com/umdjs/umd . This allows people to utilize diacritics in the browser via requirejs. The merge diff likes a nightmare but that's because it increased the indent level by 1 due to the wrapper. I didn't change any of the code inside the wrapper if you delete the wrapper and undo the indent you'll see no changes. It will continue to function in Node as it did before.