Fix bug with getting sequential model layers; Add compatability for R >3.4#13
Open
nateGeorge wants to merge 5 commits into
Open
Fix bug with getting sequential model layers; Add compatability for R >3.4#13nateGeorge wants to merge 5 commits into
nateGeorge wants to merge 5 commits into
Conversation
Author
|
Seems like the checks are failing on the introduction.Rmd file in the vignettes. It looks like some of the code blocks are blank (e.g. line 47). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug introduced by the newest version of
kerason CRAN where model layers are accessed viamodel$get_config()now instead ofmodel$get_config()$layers. It also lowers the R version requirement to 3.4 for base Ubuntu users. Addresses #12