Fix lint warnings in SysUI snippets - #1012
Open
kkuan2011 wants to merge 1 commit into
Open
Conversation
- GlanceSnippets: Fix ComposableNaming warning on Example3 - PictureInPictureSnippets: Clean up obsolete Android 8.0 (API 26) outer scaffolding checks - AndroidManifest: Add tools:ignore="DataExtractionRules" to application tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR resolves Android Lint warnings and cleans up obsolete platform version scaffolding in SystemUI snippets for:
List of Modifications:
ComposableNamingwarning by renaming@Composable fun example3()to@Composable fun Example3()(outside region tags).Build.VERSION_CODES.O/ API 26) outer scaffolding checks and unused@RequiresApi(Build.VERSION_CODES.O)annotations from Composable wrappers. All 15 PiP region tag contents remain 100% textually identical.tools:ignore="DataExtractionRules"to<application>incompose/snippets/src/main/AndroidManifest.xmlto resolve the Android 12 backup rule warning.Verification:
./gradlew :compose:snippets:lintDebug: Passed with 0 errors and 0 warnings across all 15 SystemUI files../gradlew :compose:snippets:compileDebugKotlin --rerun-tasks:BUILD SUCCESSFULwith 0 compiler warnings../gradlew :compose:snippets:assembleDebug:BUILD SUCCESSFUL../gradlew :compose:snippets:spotlessApply: Formatting verified clean.