Update HealthConnectManager.kt, specifically the "!=null" - #1024
Open
brenda-shaw wants to merge 1 commit into
Open
Update HealthConnectManager.kt, specifically the "!=null" #1024brenda-shaw wants to merge 1 commit into
brenda-shaw wants to merge 1 commit into
Conversation
Requesting to update "!=null". The standalone APK version of Health Connect on Android 13/12, or across specific IPC serialization boundaries—ReadRecordsResponse.pageToken can return an empty string ("") instead of null when pagination is complete.
Because "" != null evaluates to true, the loop condition fails to terminate. This causes severe downstream effects for integrating apps, including infinite loops, rate limit exhaustion, and potential application crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting to update "!=null". The standalone APK version of Health Connect on Android 13/12, or across specific IPC serialization boundaries—ReadRecordsResponse.pageToken can return an empty string ("") instead of null when pagination is complete.
Because "" != null evaluates to true, the loop condition fails to terminate. This causes severe downstream effects for integrating apps, including infinite loops, rate limit exhaustion, and potential application crashes.