-
Notifications
You must be signed in to change notification settings - Fork 913
BugFix: Fix DV playback if SDR fallback is added to the manifest #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -940,8 +940,13 @@ private static List<MediaCodecInfo> getDecoderInfos( | |
| return alternativeDecoderInfos; | ||
| } | ||
| } | ||
| return MediaCodecUtil.getDecoderInfosSoftMatch( | ||
| mediaCodecSelector, format, requiresSecureDecoder, requiresTunnelingDecoder); | ||
| if (MimeTypes.VIDEO_DOLBY_VISION.equals(format.sampleMimeType)) { | ||
| return MediaCodecUtil.getDecoderInfosSoftMatchFilteredByFormatSupport( | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We replace getDecoderInfosSoftMatch() with getDecoderInfosSoftMatchFilteredByFormatSupport() to resolve below two issues:
|
||
| context, mediaCodecSelector, format, requiresSecureDecoder, requiresTunnelingDecoder); | ||
| } else { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To minimize the risk, we just apply our new method MediaCodecUtil.getDecoderInfosSoftMatchFilteredByFormatSupport() to Dolby Vision only. In theory, we think this method should be applied to other formats too. |
||
| return MediaCodecUtil.getDecoderInfosSoftMatch( | ||
| mediaCodecSelector, format, requiresSecureDecoder, requiresTunnelingDecoder); | ||
| } | ||
| } | ||
|
|
||
| @RequiresApi(26) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback decoder could be HDR too. For example,
If the target device is not Dolby Vision licensed, HEVC/HEVC/AV1 decoder will be primary decoder. And the corresponding base layer content is still HDR content.