Add dby1 compatible brand to the ftyp box if muxing Dolby Content - #3369
Open
ybai001 wants to merge 1 commit into
Open
Add dby1 compatible brand to the ftyp box if muxing Dolby Content#3369ybai001 wants to merge 1 commit into
ybai001 wants to merge 1 commit into
Conversation
This updates both regular MP4 and fragmented MP4 writer paths so Dolby outputs advertise the expected compatible brand in the container header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "compatible brands" is part of 'ftyp' box, which is defined in ISO 14496-12. The usage of 'dby1' (Dolby compatible brand) is in https://professionalsupport.dolby.com/s/article/How-to-signal-Dolby-Vision-in-ISOBMFF-format-AKA-mp4-container?language=en_US
This PR updates both regular MP4 and fragmented MP4 writer paths so Dolby outputs advertise the expected compatible brand in the container header.