Skip to content

Comments

Using fs::path for file path in arguments#88

Merged
andrsd merged 2 commits intomainfrom
fs-path
Feb 22, 2026
Merged

Using fs::path for file path in arguments#88
andrsd merged 2 commits intomainfrom
fs-path

Conversation

@andrsd
Copy link
Owner

@andrsd andrsd commented Feb 22, 2026

No description provided.

@andrsd andrsd self-assigned this Feb 22, 2026
@andrsd andrsd added the feat New feature or request label Feb 22, 2026
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.71%. Comparing base (645db3b) to head (d7fc1d7).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/file.cpp 88.23% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          13       13           
  Lines         705      705           
=======================================
  Hits          703      703           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrsd and others added 2 commits February 22, 2026 07:16
Convert open(), create(), and append() methods to use fs::path instead
of std::string for filepath parameters. This provides better type safety
and consistency with the File constructor which already uses fs::path.

The change is backwards compatible due to implicit conversion from
std::string to fs::path.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@andrsd andrsd merged commit 2d7d9ba into main Feb 22, 2026
7 of 8 checks passed
@andrsd andrsd deleted the fs-path branch February 22, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant