[experimental] Custom cop for detecting missing select#227
Draft
andyatkinson wants to merge 1 commit intomainfrom
Draft
[experimental] Custom cop for detecting missing select#227andyatkinson wants to merge 1 commit intomainfrom
andyatkinson wants to merge 1 commit intomainfrom
Conversation
Owner
Author
|
GitLab Rails Rubocop that I like:
|
Should probably add pluck() An explicit select clause, e.g. select(:id), could be a better way to get started to embrace a "restrictive by default" approach This could be set up to require no bare Model.all etc. without an explicit select clause and a list of fields
andyatkinson
force-pushed
the
chore/rubocop-detect-missing-select
branch
from
a7f9dad to
d71e4fa
Compare
andyatkinson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit select clause, e.g. select(:id), could be a better way to
get started to embrace a "restrictive by default" approach
This could be set up to require no bare Model.all etc. without an
explicit select clause and a list of fields
Putting in examples like
Trip.where(id: 1)in a file, running Rubocop for that file:bundle exec rubocop app/controllers/api/trip_requests_controller.rb app/controllers/api/trip_requests_controller.rb:20:5: C: [Correctable] \ Custom/ExplicitSelect: Avoid using where without an explicit .select(...). \ Autocorrecting to .select(:id).