refactor: iterative water-filling for available space delta#131
Open
andyhorn wants to merge 1 commit into
Open
refactor: iterative water-filling for available space delta#131andyhorn wants to merge 1 commit into
andyhorn wants to merge 1 commit into
Conversation
…illing Replaces the recursive implementation that rebuilt changeable indices, maximum allowances, and full index lists per recursion. The iterative loop reuses a single mutable working-sizes buffer and saturates at least one child per pass, bounding total work at O(n^2) with much smaller constants. Closes #118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_distributeAvailableSpaceDeltawith an iterative water-filling loop that reuses a single mutable working-sizes buffer.Test plan
flutter test— all 145 tests pass, including the#setAvailableSpacecases that exercise the expand-with-max-constraint redistribution path.dart analyze lib/src/resizable_controller.dart— clean.🤖 Generated with Claude Code