perf: replace Decimal arithmetic in expand layout with doubles (#121)#132
Open
andyhorn wants to merge 1 commit into
Open
perf: replace Decimal arithmetic in expand layout with doubles (#121)#132andyhorn wants to merge 1 commit into
andyhorn wants to merge 1 commit into
Conversation
`_getExpandSizes` ran allocation-heavy Decimal math on every layout pass, with `Decimal.parse(toString())` conversions inside the iteration loop. Pixel layout doesn't need rational precision, so this swaps the inner loop to native double arithmetic and bounds iteration count to defend against floating-point residue. Drops the `decimal` dependency. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decimalmath in_getExpandSizeswith native double arithmetic. The Decimal-based loop ranDecimal.parse(toString())conversions on every layout pass and allocated on every operation; pixel layout doesn't need rational precision.expandIndices.length + 2to defend against FP residue keepingdidChange=true.decimaldependency frompubspec.yamland removes the now-unusedtoDecimal()extension.Closes #121.
Test plan
flutter analyze— cleanflutter test— all tests pass (expand math tests use exactly-representable values: 198, 398, 300, 100, 500; no rounding fixup needed)🤖 Generated with Claude Code