perf: drop per-divider LayoutBuilder; resolve cross-axis upstream#133
Open
andyhorn wants to merge 1 commit into
Open
perf: drop per-divider LayoutBuilder; resolve cross-axis upstream#133andyhorn wants to merge 1 commit into
andyhorn wants to merge 1 commit into
Conversation
The divider's main-axis size is constant (thickness + padding), and its cross-axis size is already determined by the parent's tight constraints. The inner LayoutBuilder just read back what the parent supplied, so remove it and resolve the cross-axis paint dimension upstream in ResizableContainer (the outer LayoutBuilder) before constructing the divider widget. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LayoutBuildereven though its main-axis size is constant (thickness + padding) and its cross-axis size is already fixed by the tightBoxConstraintsthe parent supplies.ResizableContainer(using the outerLayoutBuilder'sconstraints) via a newresolveDividerCrossAxisSize(length, max)helper, and passes it toResizableContainerDivideras a requiredcrossAxisSizeparameter. The innerLayoutBuilderand_getWidth/_getHeighthelpers are gone.pixels→min(pixels, max),expand→max,ratio→max * ratio,shrink→0); no public API change (ResizableContainerDivideris internal tosrc/).Test plan
dart analyzecleanvery_good test)resolveDividerCrossAxisSize🤖 Generated with Claude Code