Make downloading faster and more efficient#12
Open
zeevox wants to merge 1 commit into
Open
Conversation
* Use multiprocessing for significantly faster downloads that actually max out the available bandwidth * Add persistent caching to skip unnecessary requests (this is useful when downloading a massive collection of photos for archival and the connection is interrupted or the program exits due to an error; would need to be disabled if fetching new content from the collection of a user that has previously been downloaded) * Minor bug fixes, reformatting, refactoring... Signed-off-by: Timothy Langer <zeevox.dev@gmail.com>
|
Can confirm: works like a charm 👍 |
|
[I would raise this as an issue on your repo @zeevox but it seems that issues are not enabled] Though the caching needs a bit of work and can be confusing. I ran it without the session cookie the first time, to see what it could see publicly. After adding the session key it still only found the same public albums (due to the caching). Deleting the cache folder solved this, but it was rather confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diskcachelibrary to skip unnecessary requests (this is useful when downloading a massive collection of photos for archival and the connection is interrupted or the program exits due to an error; this feature would need to be disabled if fetching new content from the collection of a user that has previously been downloaded)NB: I made these changes to the code for myself, and only later thought of submitting a pull request. Perhaps this does not fit with the author's vision of the project and that is absolutely fine. I leave it here for those interested users with a similar use-case to mine.