A few changes to the original code#23
Open
AnakinFoxe wants to merge 11 commits into
Open
Conversation
Authenticate with password
Owner
|
Sorry for the late reply, I appreciate the changes! I'm a bit hesitant on the password authentication due to some unhandled edge cases (e.g. what if the user has 2FA enabled?). Maybe we could keep both the user/pass and session token auth mechanisms instead of replacing it. As for the Makefile, I would like to keep this script platform-independent so I don't want to merge in a Unix-specific script. At some point a setup.py / pyproject.toml may be appropriate. The other contributions are great but they probably need to be split off as separate PRs. |
sigma-cache
reviewed
Aug 1, 2024
Author
|
@andyjsmith thanks for the comments! I have updated the PR with following changes (updated the PR description as well)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this great script. It helped me download all the albums for my kid 😆
Made a few changes to the original code:
-p PASSWORDoption), however if session ID is provided, password will be ignored.--folderto download all the albums under the specific folderSmugMugDownloaderlogging@retryto manage retry forget_json()UseMakefileto setup a virtual environment to work with