Skip to content

Interpreter thread-safety#117

Open
maxcai314 wants to merge 65 commits intomainfrom
retry-sigpoly
Open

Interpreter thread-safety#117
maxcai314 wants to merge 65 commits intomainfrom
retry-sigpoly

Conversation

@maxcai314
Copy link
Copy Markdown
Collaborator

@maxcai314 maxcai314 commented Mar 22, 2025

This pull request completely reimagines the way we handle gc pauses, scheduling, and instruction patching.
The code still supports single-threaded execution, with a cleaner API.

While bjvm isn't entirely ready for multithreaded workers, it's getting there
Class loading and vm heaps still need some locks

maxcai314 added 30 commits March 6, 2025 14:30
@maxcai314
create a branch for this pthread stuff
6c51498
@maxcai314
get rid of the monitorexit handler hack- now ew can just directly mon…
a0054f8 
…itor enter
@maxcai314
better booleans
821c6e8
@maxcai314
threadproof some of the code
eb12ea6
@maxcai314
make smoe more things synchronize on the scheduler- it's not fully do…
38c7380 
…ne but it's getting there
@maxcai314
oops you need to initialize wakeup_us
81269e8
@maxcai314
make some method and structs
fb08e1f
@maxcai314
big refactor of the scheduler to make it easier to multithread- big b…
7fb322c 
…ig big, and all the tests work on my computer
@maxcai314
another HUGE refactor. make the GC synchronize on the scheduler threa…
4fe5af2 
…d pool. this should theoretically make everything thread-safe except for bump allocation, which needs a light dashing of atomics
@maxcai314
move heap stuff into a substructure in the vm struct so that it's eas…
29da781 
…ier for me to check accesses in the future concurrency
@maxcai314
thread-safe bump allocation using __atomic_fetch_add
41b93d6
@maxcai314
404 bug not found
e3cd334
@maxcai314
Merge branch 'main' into multithreaded-workers
14a6da7
@maxcai314
uhhhhh
7490f80
@maxcai314
delegating to one singular worker thread works
d2b87c0
@maxcai314
wow
644c635
@maxcai314
basic prove of consept of worker thread scheduling... there's a bunch…
54f66c1 
… of things that still need synchronization
@maxcai314
huge merge d' branch 'main' into multithreaded-workers
53cddc9
@maxcai314
I think (?) I've made the class linking/initialization synchronized p…
fabbf0e 
…roperly. but I don't know enough to know for sure
@maxcai314
add a deregister function to the worker thread pool to handle exit of…
a3116dd 
… threads
@maxcai314
add bytecode patching features, but i can't wrangle the interpreting …
23c4e3d 
…codebase api
@maxcai314
implement once but not for all
362ef25
@maxcai314
atomic method bytecode resolve patching- works in conjunction with th…
fd6923a 
…e buffer for patching polymorphic calls
@maxcai314
huge refactor of system- i can't figure out why it does a bad access …
4176aeb 
…of nullptr
@maxcai314
make it work with both tails and no tails
8253be8
@maxcai314
cope with the interpreter design, change a bunch of things to be more…
2661f00 
… threadsable
@maxcai314
debug... putstatic has issues
76b6d0d
@maxcai314
omg i genuienly made the interpter work im so happy
aa88939
@maxcai314
funny
3c37ed4
@maxcai314
incremental change- things still work
1ab4930
maxcai314 and others added 25 commits March 22, 2025 17:17
@maxcai314
add libatomic to target compile options (idk if this is the right place
d8a88c8
@maxcai314
Revert "add libatomic to target compile options (idk if this is the r…
3ddceed 
…ight place"

This reverts commit d8a88c8.
@anematode
Update CMakeLists.txt
52a91e4
@maxcai314
unsafe allocations are now protected
a3b2274
@maxcai314
big - Merge branch 'main' into retry-sigpoly
14b8d1f
@maxcai314
fix merge problems
657eb2e
@maxcai314
add latomic
733b449
@maxcai314
hopefully
6fe376f
@maxcai314
is it a compile option or a link option
a410b9a
@maxcai314
i don't know what im diong
131ebe7
@maxcai314
this is really cooked
f2a20c6
@maxcai314
print stuff maybe
d56c1b3
@maxcai314
versus pointersize hopefully
7cfe1d5
@maxcai314
once and for all, using C code checking
09857e6
@maxcai314
move it to a special cmake file that is included, and adds to bjvm_st…
5f02e86 
…atic instead of everywhere
@maxcai314
disable N-body problem. im getting impatient
2848bbf
@maxcai314
remove useless var
819bf67
@maxcai314
cmake pthread check
bc2d00b
@maxcai314
fix reentrancy bugs that caused deadlock- make an internal impl versi…
0b0fd1a 
…on of function
@maxcai314
resolve bug of reentrancy in array classdesc making
9ad4cab
@maxcai314
make impl implementation for initialize_class
6f11fe4
@maxcai314
Revert "make impl implementation for initialize_class"
c8e7eaa 
This reverts commit 6f11fe4.
@maxcai314
use recursive mutex for classdesc->lock
25b6f66
@maxcai314
fix insanely stupid memory leak
ddc784f
@maxcai314
fix memory leak: missing free_heap_str on early returns in Class#forN…
83e5623 
…ame0 native
@maxcai314
Copy link
Copy Markdown
Collaborator Author

maxcai314 commented Apr 10, 2025

wesh why is CI stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxcai314 @anematode