SIANXKE-473: implement solver that directly uses the Gurobi API#13
Open
MLackenbucher wants to merge 1 commit intoanexia:mainfrom
Open
SIANXKE-473: implement solver that directly uses the Gurobi API#13MLackenbucher wants to merge 1 commit intoanexia:mainfrom
MLackenbucher wants to merge 1 commit intoanexia:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
===========================================
- Coverage 76.69% 66.20% -10.49%
===========================================
Files 45 46 +1
Lines 811 944 +133
Branches 92 115 +23
===========================================
+ Hits 622 625 +3
- Misses 144 274 +130
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markstrempel
suggested changes
Oct 17, 2025
CHANGELOG.md
Outdated
| - Added possibility to use Gurobi Solver directly via the API, not using Google OR-Tools. | ||
|
|
||
| ### Changed | ||
| - Usage of AdditionalSolverParmateters. Changed list of string to list ob key-value pairs. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Usage of AdditionalSolverParmateters. Changed list of string to list ob key-value pairs. | |
| - Usage of AdditionalSolverParmateters. Changed list of string to list of key-value pairs. |
README.md
Outdated
Comment on lines
+102
to
+103
| - Key mapping shortcuts are applied for NumberOfThreads and RelativeGap; AdditionalSolverSpecificParameters are forwarded as-is. | ||
| - TimeLimitInMilliseconds is mapped to the solver’s native time limit. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Key mapping shortcuts are applied for NumberOfThreads and RelativeGap; AdditionalSolverSpecificParameters are forwarded as-is. | |
| - TimeLimitInMilliseconds is mapped to the solver’s native time limit. | |
| - The AdditionalSolverSpecificParameters are forwarded as-is. | |
| - NumberOfThreads, TimeLimitInMilliseconds, and RelativeGap is mapped to the solver’s native time limit. |
| : MemberwiseEquatable<IlpSolver>, | ||
| IOptimizationSolver<IIntegerVariable<IRealScalar>, IRealScalar, IRealScalar, RealScalar> | ||
| { | ||
| private ILogger<IlpSolver>? Logger { get; } = logger; |
Contributor
There was a problem hiding this comment.
we don't need an extra property we can use the primary constructor parameter directly.
| env.Start(); | ||
| var gurobiModel = new GRBModel(env); | ||
|
|
||
|
|
| gurobiModel.AddVar(item.Interval.LowerBound.Value, item.Interval.UpperBound.Value, 0, GRB.INTEGER, | ||
| item.Name)); | ||
|
|
||
| var cnt = 1; |
Contributor
There was a problem hiding this comment.
use descriptive variable name
|
|
||
| gurobiModel.Optimize(); | ||
|
|
||
|
|
Comment on lines
+99
to
+103
| catch (Exception e) | ||
| { | ||
| Logger?.LogError(e, "An error occurred during solving the model: {EMessage}", e.Message); | ||
| throw; | ||
| } |
Contributor
There was a problem hiding this comment.
remove try catch to fix warning
|
|
||
| namespace Anexia.MathematicalProgram.Tests.Solve; | ||
|
|
||
| public sealed class GurobiSolverTest |
Contributor
There was a problem hiding this comment.
Suggested change
| public sealed class GurobiSolverTest | |
| public sealed class GurobiNativeSolverTest |
MLackenbucher
force-pushed
the
feature/MLA_SIANXKE-473_gurobi-without-ortools
branch
from
4c2f431 to
a9068ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.