Update extraction pipeline to per-region as opposed to aggregate - #34
Open
alex-l-kong wants to merge 5 commits into
Open
Update extraction pipeline to per-region as opposed to aggregate#34alex-l-kong wants to merge 5 commits into
alex-l-kong wants to merge 5 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
An entire MALDI dataset across a whole TMA is extremely expensive to extract and analyze. To improve efficiency, we update the pipeline to run on a per-region basis.
How did you implement your changes
We use the poslog to identify which coordinate belongs to which region. This is similar to the workflow for the core cropping step. By specifying a
region_numparam during the extraction process, we can exclude coordinates outside the region of interest.Remaining issues
Potential improvements