AMD64: Set fp_ret_offset#349
Merged
Merged
Conversation
AMD64 SysV returns float/double in xmm0 (offset 224). Without this, the decompiler's AIL converter never created fp_ret_expr for call statements, so FP return values from calls were lost.
4 tasks
Member
|
This is probably good to merge as-is, but the calling convention stuff in archinfo is a bit of a hackjob since it should really be handled on a per-calling-convention basis. |
Member
Author
Agree |
Member
It requires a much bigger refactor especially in the static analysis realm. |
Member
Can we replace the use of archinfo constants with the equivalent value from the default calling convention? |
Member
Author
|
I don't plan to address the architectural issues or refactoring in this PR, we'll handle it in a follow up |
Member
|
Can we just merge this PR? I think it's good enough as it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD64 SysV returns float/double in xmm0 (offset 224). Without this, the decompiler's AIL converter never created fp_ret_expr for call statements, so FP return values from calls were lost.