Skip to content

refactor: replace capital letters with normal letters on our navbar #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ftonato wants to merge 6 commits into from
Closed

refactor: replace capital letters with normal letters on our navbar #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e21210d
refactor: replace capital letters with normal letters on our navbar
ftonato Oct 17, 2021
200e993
chore: update package-lock & yarn.lock
ftonato Oct 20, 2021
49fa1fd
chore: update github wrokflow files
ftonato Oct 20, 2021
217b463
chore: prettify our files
ftonato Oct 20, 2021
5c46448
chore: update home file with prettier
ftonato Oct 22, 2021
319b46c
Merge branch 'anitab-org:develop' into refactor/update-navibar-capita…
ftonato Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Prettify code
uses: creyD/prettier_action@v4.0
with:
prettier_options: "--write src/**/*.{ts,jsx,js,css,html,json,md}"
prettier_options: --write src/**/*.{ts,jsx,js,css,html,json,md}
Copy link
Copy Markdown
Member

@isabelcosta isabelcosta Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed, is there any reason why this was reverted and why package-lock.json and yarn.lock have so many changes?

Copy link
Copy Markdown
Contributor Author

@ftonato ftonato Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that the quotes are not necessary (and not suggested in the plugin's official documentation) so I removed it!

Copy link
Copy Markdown
Contributor Author

@ftonato ftonato Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock has a lot of changes because I tried to rebase it with develop (it still fails)

Copy link
Copy Markdown
Member

@isabelcosta isabelcosta Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert those file changes (yarn.lock and package-lock.json)? And keep this PR to the changes related to the ticket?

only_changed: True
build:
# The type of runner that the job will run on
Expand Down
31 changes: 15 additions & 16 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,28 @@ name: PR Safe Check

on:
pull_request:
branches: [ develop ]
branches: [develop]
types: [opened, synchronize, reopened]
push:
branches: [ develop ]
branches: [develop]

jobs:
build_check:

runs-on: ubuntu-latest
strategy:
matrix:
node: [ '14', '16' ]
node: ['14', '16']
name: Node.js v${{ matrix.node }}
steps:
- name: 🛎 Checkout
uses: actions/checkout@v2
- name: 🚀 Use Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
- name: ⚙️ Install dependencies
run: npm install
- name: 🔍 Run tests
run: npm test
- name: 🔨 Build the project
run: npm run build
- name: 🛎 Checkout
uses: actions/checkout@v2
- name: 🚀 Use Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
- name: ⚙️ Install dependencies
run: npm install
- name: 🔍 Run tests
run: npm test
- name: 🔨 Build the project
run: npm run build
Loading