Add writing_role configuration for database connection switching#19
Open
joshuajansen wants to merge 5 commits intoankane:masterfrom
Open
Add writing_role configuration for database connection switching#19joshuajansen wants to merge 5 commits intoankane:masterfrom
joshuajansen wants to merge 5 commits intoankane:masterfrom
Conversation
|
This would be a great addition. I got a question, where would |
|
Just throwing out a random idea incase it is possible without too much work. Is there a possibility to instruct rollup to use replica? e.g. Then use rollup as usual? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #18 by adding a
writing_rolesetting that gets used to wrap thesave_recordscall in therollupmethod in. If not configured it'll call and return block directly by default.Usage could look something like this for the implementing codebase:
Which would then fetch the data from the replica and then switch to writing the rollup to rollups using the writing role.
I'm very open to a less monkey-patchy way of testing this! And of course to any feedback on the implementation in general.