Enable deck option target selection in study screen #19963
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Copyright (c) 2025 lukstbit <52494258+lukstbit@users.noreply.github.com> | ||
| * | ||
| * This program is free software; you can redistribute it and/or modify it under | ||
| * the terms of the GNU General Public License as published by the Free Software | ||
| * Foundation; either version 3 of the License, or (at your option) any later | ||
| * version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, but WITHOUT ANY | ||
| * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A | ||
| * PARTICULAR PURPOSE. See the GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License along with | ||
| * this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package com.ichi2.anki.dialogs | ||
|
|
||
| import android.content.Context | ||
| import android.view.LayoutInflater | ||
| import android.view.View | ||
| import android.view.ViewGroup | ||
| import android.widget.ArrayAdapter | ||
| import android.widget.TextView | ||
| import com.google.android.material.dialog.MaterialAlertDialogBuilder | ||
| import com.ichi2.anki.CollectionManager.TR | ||
| import com.ichi2.anki.R | ||
| import com.ichi2.anki.common.annotations.NeedsTest | ||
| import com.ichi2.anki.databinding.DialogDeckOptionsSelectionBinding | ||
| import com.ichi2.anki.pages.DeckOptionsEntry | ||
| import com.ichi2.anki.ui.windows.reviewer.ReviewerFragment | ||
| import com.ichi2.anki.ui.windows.reviewer.ReviewerViewModel | ||
| import com.ichi2.anki.utils.ext.usingStyledAttributes | ||
| import com.ichi2.utils.create | ||
| import com.ichi2.utils.customView | ||
| import com.ichi2.utils.title | ||
| import timber.log.Timber | ||
|
|
||
| /** | ||
| * Shows a list of decks from which the user can select one to display its deck options. | ||
| * @see ReviewerFragment | ||
| * @see ReviewerViewModel.emitDeckOptionsDestination | ||
| */ | ||
| @NeedsTest("verify null deck names => null entry") | ||
| fun Context.showDeckOptionsSelectionDialog( | ||
| options: List<DeckOptionsEntry>, | ||
| onDeckSelected: (DeckOptionsEntry) -> Unit, | ||
| ) { | ||
| Timber.i("Showing deck options selection dialog") | ||
| val binding = DialogDeckOptionsSelectionBinding.inflate(LayoutInflater.from(this)) | ||
| val normalDeckNameColor: Int = | ||
| usingStyledAttributes(null, intArrayOf(android.R.attr.textColor)) { | ||
| getColor(0, 0) | ||
| } | ||
| val dynamicDeckNameColor: Int = | ||
| usingStyledAttributes(null, intArrayOf(R.attr.dynDeckColor)) { | ||
| getColor(0, 0) | ||
| } | ||
| val dialog = | ||
| MaterialAlertDialogBuilder(this).create { | ||
| title(text = TR.deckConfigWhichDeck()) | ||
| customView(binding.root) | ||
| } | ||
| binding.deckOptionsList.adapter = | ||
| object : ArrayAdapter<String>( | ||
| this, | ||
| R.layout.item_deck_option_selection, | ||
| options.map { it.name.toString() }, | ||
| ) { | ||
| override fun getView( | ||
| position: Int, | ||
| convertView: View?, | ||
| parent: ViewGroup, | ||
| ): View { | ||
| val rowView = super.getView(position, convertView, parent) as TextView | ||
| rowView.setTextColor(if (options[position].isFiltered) dynamicDeckNameColor else normalDeckNameColor) | ||
| rowView.setOnClickListener { | ||
| dialog.dismiss() | ||
| onDeckSelected(options[position]) | ||
| } | ||
| return rowView | ||
| } | ||
| } | ||
| dialog.show() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <ListView xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:id="@+id/deck_options_list" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:paddingHorizontal="24dp" | ||
| android:paddingVertical="16dp" | ||
| tools:listitem="@layout/item_deck_option_selection" | ||
| /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <com.ichi2.ui.FixedTextView xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:id="@+id/deck_option" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:minHeight="?attr/listPreferredItemHeight" | ||
| android:paddingVertical="8dp" | ||
| android:textAppearance="?attr/textAppearanceListItemSecondary" | ||
| android:gravity="center_vertical|start" | ||
| android:background="?attr/selectableItemBackground" | ||
| tools:text="Deck option target" | ||
| /> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need for this return?