Skip to content

Fix(WhiteBoard): Prevent Integer display wrapping#20333

Open
LUwUcifer wants to merge 1 commit intoankidroid:mainfrom
LUwUcifer:largeFontSizeFix
Open

Fix(WhiteBoard): Prevent Integer display wrapping#20333
LUwUcifer wants to merge 1 commit intoankidroid:mainfrom
LUwUcifer:largeFontSizeFix

Conversation

@LUwUcifer
Copy link

@LUwUcifer LUwUcifer commented Feb 17, 2026

Purpose / Description

#20332 When Android Device Font Size is set to Largest with Default View, Eraser Size Integer wraps at 3 digit numbers

Fixes

Fixes #20332

Approach

  1. Changed reviewer.whiteboard.EraserButton layout_width from ?minTouchTargetSize to wrap_content
  2. Changed minWidth from 0dp to ?minTouchTargetSize

This approach negates the clipping from the static width of 48dp from minTouchTargetSize and allows for wrapping in case of large fonts, and sets minWidth to minTouchTargetSize to meet Accessibility Criteria

How Has This Been Tested?

This has been tested on a local Android Device of 17.06cm display, width accessibility has been confirmed using Layout Inspector in Android Studio

Learning (optional, can help others)

While considering small texts, setting static widths may cause issues with large default fonts in Accessibility

Links to blog posts, patterns, libraries or addons used to solve this problem
N/A

Checklist

Please, go through these checks before submitting the PR.

  • [✓] You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • [✓] You have performed a self-review of your own code
  • [✓] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [✓ ] UI Changes: You have tested your change using the Google Accessibility Scanner

…argetSize to wrap_content, subsequently changed minWidth from 0dp(unsure why it was this) to ?minTouchTargetSize
@LUwUcifer
Copy link
Author

While checking the app through Google Accessibility Scanner, it did flag some other issues with the whiteboard, is it cool if i work on those too?

@ShaanNarendran
Copy link
Contributor

feel like the commit message could be shortened, and the rest could be moved into the description

@LUwUcifer LUwUcifer changed the title Fix(WhiteBoard): Prevent Integer displaying eraser size to wrap to another row while using whiteboard in large font size Fix(WhiteBoard): Prevent Integer display wrapping Feb 17, 2026
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Second Approval Has one approval, one more approval to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eraser size number wraps to 2 lines

3 participants

Comments